Settings: update learn more info #9137
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
eliorivero
added
[Type] Enhancement
eliorivero
force-pushed
the
update/learn-more-info
branch
from
982509a to
4865f26
Compare
oskosk
reviewed
Mar 23, 2018
|
|
||
| SettingsGroup.propTypes = { | ||
| support: PropTypes.string, | ||
| // support: PropTypes.string, |
eliorivero
added
[Status] Needs Review
Contributor
Author
|
@rickybanister since @nicoleckohler suggested that we should add another info popover for portfolios, I added it and wanted to know if it's ok that it looks like this now or if we should keep the previous appearance Before
After
|
eliorivero
added
[Status] Needs Review
|
Yes indeed, splitting it is great. |
|
Will you able to follow up the jetpack prs with similar changes in calypso? |
Contributor
Author
|
Sure, I will 👍 |
|
❤️ |
This was referenced Mar 23, 2018
…b. Introduce new settings group for portfolios in custom content types. Refactor theme enhancements to remove unnecessary code
… link properties so this prop is no longer a string. Remove unnecessary code and set right prop type and default value.
…nk provided, it verifies that no link will be rendered
eliorivero
force-pushed
the
update/learn-more-info
branch
from
0862e2d to
f648d5c
Compare
oskosk
added
[Status] Ready to Merge
ghost
removed
[Status] Needs Changelog
[Status] Ready to Merge
dereksmart
pushed a commit
that referenced
this pull request
Mar 27, 2018
* Changelog 6.0: create base for changelog. * Add #8938 to changelog * Add #8962 to changelog * Add #8974 to changelog * Add #8975 to changelog * Add #8978 to changelog * Add #8867 to changelog * Add #8937 to changelog * Add #8961 to changelog * Add #8855 to changelog * Add #8944 to changelog * Add #8973 to changelog * Add #8977 to changelog * Add #8979 to changelog * Add #8980 to changelog * Add #8982 to changelog * Add #8983 to changelog * Add #8984 to changelog * Add #8986 to changelog * Add #9005 to changelog * Add #9010 to changelog * Add #9012 to changelog * Add #9021 to changelog * Add #9022 to changelog * Add #9056 to changelog * Add #9061 to changelog * Add #9079 to changelog * Add #9080 to changelog * Add #9088 to changelog * Add #9096 to changelog * Add #9097 to changelog * Add #9100 to changelog * Add #9107 to changelog * Add #8969 to changelog * Add #8993 to changelog * Add #9003 to changelog * Add #9031 to changelog * Add #8945 to changelog * Add #9052 to changelog * Add #9058 to changelog * Add #9066 to changelog * Add #9076 to changelog * Add #9053 to changelog * Add #9108 to changelog * Add #9135 to changelog * Add #9148 to changelog * Add #9125 to changelog * Add #9137 to changelog * Added testing instructions for 6.0. * Added IS testing instructions, huge props to @tiagonoronha. * Added #8498 to changelog. * Added #8954 to changelog. * Added #8985 to changelog. * add #9027 * add #9112 to changelog * add #9136 to changelog * add #9102 to changelog * add #9093 to changelog * add #9062 to changelog * add #9172 to changelog
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #8922
Changes proposed in this Pull Request:
supportproperty ofSettingsGroupcomponent is no longer a string and no longer receives a URL. It receives and object withtextandlinkproperties, that are the text blurb and the link to the support doc respectively.Popovers now look like this with the text and link
Testing instructions:
Proposed changelog entry for your changes: