Skip to content

Conversation

@oskosk
Copy link
Contributor

@oskosk oskosk commented Mar 16, 2018

Fixes p1HpG7-4X1-p2
Fixes #9044.

Changes proposed in this Pull Request:

  • Sets the jetpack_masterbar_should_logout_from_wpcom to be true by default.

Testing instructions:

  • Activate masterbar
  • Sign out from the site
  • Expect to be signed out from WordPress.com too.

Proposed changelog entry for your changes:

  • Made the Sign Out link in the Master always log you out from WordPress.com

@oskosk oskosk added [Status] Needs Review This PR is ready for review. [Feature] Masterbar WordPress.com Toolbar and Dashboard customizations labels Mar 16, 2018
@oskosk oskosk requested a review from a team as a code owner March 16, 2018 02:23
@oskosk oskosk added this to the 6.0 milestone Mar 16, 2018
Copy link
Contributor

@zinigor zinigor left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Technically I see no problems with this, LGTM!

@zinigor zinigor added [Status] Ready to Merge Go ahead, you can push that green button! and removed [Status] Needs Review This PR is ready for review. labels Mar 16, 2018
@oskosk oskosk merged commit 87acef2 into master Mar 21, 2018
@ghost ghost removed the [Status] Ready to Merge Go ahead, you can push that green button! label Mar 21, 2018
@oskosk oskosk deleted the update/always-sign-out-masterbar branch March 21, 2018 19:05
oskosk added a commit that referenced this pull request Mar 23, 2018
dereksmart pushed a commit that referenced this pull request Mar 27, 2018
* Changelog 6.0: create base for changelog.

* Add #8938 to changelog

* Add #8962 to changelog

* Add #8974 to changelog

* Add #8975 to changelog

* Add #8978 to changelog

* Add #8867 to changelog

* Add #8937 to changelog

* Add #8961 to changelog

* Add #8855 to changelog

* Add #8944 to changelog

* Add #8973 to changelog

* Add #8977 to changelog

* Add #8979 to changelog

* Add #8980 to changelog

* Add #8982 to changelog

* Add #8983 to changelog

* Add #8984 to changelog

* Add #8986 to changelog

* Add #9005 to changelog

* Add #9010 to changelog

* Add #9012 to changelog

* Add #9021 to changelog

* Add #9022 to changelog

* Add #9056 to changelog

* Add #9061 to changelog

* Add #9079 to changelog

* Add #9080 to changelog

* Add #9088 to changelog

* Add #9096 to changelog

* Add #9097 to changelog

* Add #9100 to changelog

* Add #9107 to changelog

* Add #8969 to changelog

* Add #8993 to changelog

* Add #9003 to changelog

* Add #9031 to changelog

* Add #8945 to changelog

* Add #9052 to changelog

* Add #9058 to changelog

* Add #9066 to changelog

* Add #9076 to changelog

* Add #9053 to changelog

* Add #9108 to changelog

* Add #9135 to changelog

* Add #9148 to changelog

* Add #9125 to changelog

* Add #9137 to changelog

* Added testing instructions for 6.0.

* Added IS testing instructions, huge props to @tiagonoronha.

* Added #8498 to changelog.

* Added #8954 to changelog.

* Added #8985 to changelog.

* add #9027

* add #9112 to changelog

* add #9136 to changelog

* add #9102 to changelog

* add #9093 to changelog

* add #9062 to changelog

* add #9172 to changelog
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

[Feature] Masterbar WordPress.com Toolbar and Dashboard customizations

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants