Connection Modal: Update text to clarify when tracking begins. #9053
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Since some tracking begins upon any attempted connection, we need to clarify the statement provided alongside our connection (“Set Up Jetpack”) button so that it is apparent to folks connecting to WordPress.com.
bubel
added
[Type] Bug
beaulebens
reviewed
Mar 14, 2018
| <p className="jp-banner__tos-blurb"> | ||
| { __( | ||
| 'By connecting your site you agree to our fascinating {{tosLink}}Terms of Service{{/tosLink}} and to {{shareDetailsLink}}share details{{/shareDetailsLink}} with WordPress.com', | ||
| 'By clicking on the button below, you agree to our fascinating {{tosLink}}Terms of Service{{/tosLink}} and to {{shareDetailsLink}}share details{{/shareDetailsLink}} with WordPress.com.', |
Member
There was a problem hiding this comment.
In the interests of brevity, I'd remove "on" and just say "By clicking the button..."
Contributor
Author
|
Your penchant for brevity accepted, @beaulebens. Updated. |
zinigor
approved these changes
Mar 19, 2018
Contributor
zinigor
left a comment
zinigor
left a comment
There was a problem hiding this comment.
Merged conflicts, LGTM now!
zinigor
added
the
[Status] Ready to Merge
Contributor
|
The text in this dialog should be updated too
It's in |
dereksmart
approved these changes
Mar 26, 2018
Contributor
dereksmart
left a comment
dereksmart
left a comment
There was a problem hiding this comment.
Pushed a change to the connection banner as suggestion by @eliorivero LGTM
Contributor
|
@dereksmart in that banner you updated, there are two buttons, not just one. The text then sounds a little bit more vague in this situation Do you think it's ok like that or there should be a more specific text here ? |
Contributor
|
@oskosk good point, I reverted the change to the banner for more consideration. Let's get this one in as-is, as the title of it specifically intends to only change the modal connection view. cc @eliorivero |
Contributor
|
Alright @dereksmart . Moved this one to Milestone 6.0. Will merge when tests finish |
ghost
removed
the
[Status] Ready to Merge
dereksmart
pushed a commit
that referenced
this pull request
Mar 27, 2018
* Changelog 6.0: create base for changelog. * Add #8938 to changelog * Add #8962 to changelog * Add #8974 to changelog * Add #8975 to changelog * Add #8978 to changelog * Add #8867 to changelog * Add #8937 to changelog * Add #8961 to changelog * Add #8855 to changelog * Add #8944 to changelog * Add #8973 to changelog * Add #8977 to changelog * Add #8979 to changelog * Add #8980 to changelog * Add #8982 to changelog * Add #8983 to changelog * Add #8984 to changelog * Add #8986 to changelog * Add #9005 to changelog * Add #9010 to changelog * Add #9012 to changelog * Add #9021 to changelog * Add #9022 to changelog * Add #9056 to changelog * Add #9061 to changelog * Add #9079 to changelog * Add #9080 to changelog * Add #9088 to changelog * Add #9096 to changelog * Add #9097 to changelog * Add #9100 to changelog * Add #9107 to changelog * Add #8969 to changelog * Add #8993 to changelog * Add #9003 to changelog * Add #9031 to changelog * Add #8945 to changelog * Add #9052 to changelog * Add #9058 to changelog * Add #9066 to changelog * Add #9076 to changelog * Add #9053 to changelog * Add #9108 to changelog * Add #9135 to changelog * Add #9148 to changelog * Add #9125 to changelog * Add #9137 to changelog * Added testing instructions for 6.0. * Added IS testing instructions, huge props to @tiagonoronha. * Added #8498 to changelog. * Added #8954 to changelog. * Added #8985 to changelog. * add #9027 * add #9112 to changelog * add #9136 to changelog * add #9102 to changelog * add #9093 to changelog * add #9062 to changelog * add #9172 to changelog
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Since some tracking begins upon any attempted connection, we need to
clarify the statement provided alongside our connection (“Set Up
Jetpack”) button so that it is apparent to folks connecting to
WordPress.com.
Changelog entry
Make it clear when tracking begins in the connetion dialog.