Add new settings route and page for Privacy settings #8993

dereksmart · 2018-03-06T22:01:44Z

~~Must be merged after #9003 is merged.~~ It's merged

This PR introduces a new page accessible through the Privacy link at the bottom of the Jetpack dashboard.

The page features links to the Automattic privacy policy and to the upcoming privacy.blog. The support link goes through what data does Jetpack sync.
The page also introduces a toggle so users can opt-out of information tracking that Automattic collects for its own purpose.

Changelog entry

Introduced a new Privacy admin page linked at the bottom of the Jetpack dashboard.

eliorivero · 2018-03-08T16:10:41Z

In 805141f, I added smooth scroll that will take user to the height of the navigation bar when the Privacy link is clicked.
The reason for this is that when I clicked on the link, nothing seemed to happen. I initially thought it was broken until I scrolled up and saw that it had indeed changed.

eliorivero · 2018-03-08T16:55:47Z

_inc/client/privacy/index.jsx

+/**
+ * External dependencies
+ */
+import React from 'react';


Missing PropTypes import

eliorivero · 2018-03-08T16:57:27Z

_inc/client/privacy/index.jsx

+import SettingsGroup from 'components/settings-group';
+import { ModuleToggle } from 'components/module-toggle';
+import { updateSettings } from 'state/settings';
+import { getSettings } from 'state/settings';


These two lines import selectors from the same place. The linter should throw an error ( cc @oskosk ) because we should have a single line importing everything needed from a particular bundle of selectors.

eliorivero · 2018-03-08T16:57:45Z

_inc/client/privacy/index.jsx

+
+class Privacy extends React.Component {
+	static displayName = 'PrivacySettings';
+


Missing propTypes and defaultProps

eliorivero · 2018-03-08T16:58:10Z

_inc/client/privacy/index.jsx

+	togglePrivacy = () => {
+		const isTracksEnabled = this.props.getOptionValue( 'disable_tracking' );
+		this.props.toggleTracking( isTracksEnabled );
+	};


This can be reduced to

togglePrivacy = () => this.props.toggleTracking( this.props.getOptionValue( 'disable_tracking' ) );

eliorivero · 2018-03-08T16:59:08Z

_inc/client/privacy/index.jsx

+	render() {
+		// eslint-disable-next-line
+		console.log( this.props );
+


Maybe there should be a destructuring sentence assigning this.props

eliorivero · 2018-03-08T16:59:48Z

_inc/client/privacy/index.jsx

+					<SettingsGroup hasChild support="https://jetpack.com/support/privacy">
+						<ModuleToggle
+							compact
+							activated={ false }


Needs this.props.getOptionValue to reflect the correct state

eliorivero · 2018-03-08T17:00:10Z

_inc/client/privacy/index.jsx

+						<ModuleToggle
+							compact
+							activated={ false }
+							toggling={ false }


Needs this.props.isSavingAnyOption to toggle optimistically.

eliorivero · 2018-03-08T17:01:13Z

_inc/client/privacy/index.jsx

+		toggleTracking: ( isEnabled ) => {
+			return dispatch( updateSettings( { disable_tracking: isEnabled ? false : true } ) );
+		}
+	} )


Both mapStateToProps and mapDispatchToProps can be reduced using shorthands.

eliorivero · 2018-03-08T17:01:57Z

_inc/client/privacy/index.jsx

+			return dispatch( updateSettings( { disable_tracking: isEnabled ? false : true } ) );
+		}
+	} )
+)( Privacy );


Privacy needs to be wrapped in moduleSettingsForm

eliorivero · 2018-03-08T17:03:32Z

_inc/lib/core-api/class.jetpack-core-api-module-endpoints.php

 					$updated = get_option( $option ) !== $value ? update_option( $option, (bool) $value ) : true;
 					break;

+				case 'disable_tracking':


This is the same than above (and similar to the one below except for the !== ) so I think it's unnecessary to repeat all the code.

Issues addressed.

eliorivero · 2018-03-08T17:34:58Z

Added links to privacy policy and privacy blog.

@pesieminski @nicoleckohler can you articulate some text for the two lines that have a link? It can have any length.

eliorivero · 2018-03-08T17:38:56Z

@bubel @nicoleckohler

We need a page talking about privacy at https://jetpack.com/support/privacy

bubel · 2018-03-08T17:49:31Z

Just to confirm - I assume this is a page that will inform folks on updating their privacy settings in the UI, correct? I want to make sure we get the context correct.

eliorivero · 2018-03-09T12:58:57Z

@bubel yes, that's the general idea. I guess @pesieminski can give you more details.

pesieminski · 2018-03-09T14:24:33Z

Yes, we're creating some new privacy options in Jetpack (opt out for tracking) and more transparency/privacy docs. This is a place for them to live - both info and functionality.

dereksmart · 2018-03-09T20:16:29Z

_inc/lib/core-api/class.jetpack-core-api-module-endpoints.php

 					break;

+				case 'jetpack_event_tracking':
+					jetpack_require_lib( 'class.jetpack-user-event-tracking' );


This is throwing a fatal, can't find the lib

Oh, because of #9003

Yes. While coding this today, I extracted the class to make the updates so it works with it. We will merge this after Enej and Miguel merge the other.

pesieminski · 2018-03-09T22:41:52Z

For the beginning:

We are committed to your privacy and security.
Read about how Jetpack uses your data in Automattic Privacy Policy and What Data Does Jetpack Sync?

For the end:
See more WordPress privacy information and resources on privacy.blog.

eliorivero · 2018-03-09T23:05:31Z

Added PR description and most up to date screenshot:

bubel · 2018-03-13T14:11:33Z

I've started working on the jetpack.com support page.

bperson · 2018-03-13T16:33:23Z

👋 No idea if you're still using w.js as a Tracks library from JS, but there should be a setOptOut command that will pop out in there and block any pixel going through it. It could be used when the opt out status is being changed ( 38-gh-analytics )

jaswrks · 2018-03-16T17:13:14Z

_inc/client/components/footer/index.jsx

 							onClick={ this.trackPrivacyClick }
-							href="https://automattic.com/privacy/"
-							target="_blank"
+							href="#/privacy"


I noticed this link doesn't work from this list of all modules page:
/wp-admin/admin.php?page=jetpack_modules

Good catch @jaswrks!

Since this is the JS-version of Jetpack settings page, I think we'll want to add a new JS-free admin page that contains the texts and links plus a checkbox and submit button to disable tracking.

I'm inclined to leave this PR specifically for the JS settings page and address the issue in a new PR. We still need to have #9003 merged. Thoughts @dereksmart?

Yeah, let's take that on in another PR

jaswrks · 2018-03-16T18:03:10Z

@bperson writes...

a setOptOut command that will pop out in there and block any pixel going through it. It could be used when the opt out status is being changed ( 38-gh-analytics )

What if a user lost that cookie? The Tracks library from JS would then be out of sync with their preference in usermeta, no?

What if, in addition to the cookie, we set a JS global opt-out flag that is based on the user's current preference. 38-gh-analytics could then be updated to check for that too.

bperson · 2018-03-19T14:54:19Z

What if a user lost that cookie? The Tracks library from JS would then be out of sync with their preference in usermeta, no?

The main point is that it will block pixels requests to ever be fired, thus saving bandwidth both for the users and us :) ( + the user doesn't have to take our word for it that we aren't tracking him if there is no tracking pixels being fired ;) ). I still expect us to have a "last resort" opt-out filter in the back-end.

What if, in addition to the cookie, we set a JS global opt-out flag that is based on the user's current preference. 38-gh-analytics could then be updated to check for that too.

You mean including something like:

<script>
TRACKS_OPT_OUT = <?php echo is_user_opted_out(); ?>
</script>

I'd rather we keep with the current "usage" of w.js and have something like this, but you're right, it could be used on every page and not only on the ones where the status changes. ( for instance in Calypso, I'm trying to set it each time the user syncs his user settings )

<script>
window._tkq = window._tkq || [];
window._tkq.push( [ 'setOptOut', <?php echo is_user_opted_out(); ?> ] );
</script>

jaswrks · 2018-03-19T16:08:59Z

The main point is that it will block pixels requests to ever be fired, thus saving bandwidth both for the users and us :)

I see. Makes sense. Thank you.

jaswrks · 2018-03-20T13:49:58Z

I'm working to hook this new privacy option up to the setOptOut command in #9085

…same path. Introduce ModuleSettingsForm to use getOptionValue and isSavingAnyOption so ththe toggle now works. Simplify mapStateToProps and mapDispatchToProps. Simplify other minor code.

…ting code.

eliorivero · 2018-03-23T19:55:05Z

Rebased #9003 on this branch now that it's merged.

dereksmart · 2018-03-23T20:42:36Z

So this all works well, but I think we could also put some checks here in the client code from preventing these events from sending at all.

We could do something like if (Jetpack_User_Event_Tracking::is_disabled($current_user)) return; here in the PHP Tracks library https://github.com/Automattic/jetpack/blob/branch-5.9/_inc/lib/tracks/class.tracks-client.php#L56

And still sync the meta value back to .com to do whatever blocks we need there.

dereksmart · 2018-03-23T20:49:23Z

[edit] : I see this w.js is already being discussed above

Could also block from enqueuing w.js here https://github.com/Automattic/jetpack/blob/branch-5.9/_inc/lib/admin-pages/class.jetpack-react-page.php#L202

dereksmart · 2018-03-26T13:19:09Z

WRT to my last comments, let's do that in a separate PR. We can block these events from the server as it is.

oskosk

LGTM!

@tiagonoronha

* Changelog 6.0: create base for changelog. * Add #8938 to changelog * Add #8962 to changelog * Add #8974 to changelog * Add #8975 to changelog * Add #8978 to changelog * Add #8867 to changelog * Add #8937 to changelog * Add #8961 to changelog * Add #8855 to changelog * Add #8944 to changelog * Add #8973 to changelog * Add #8977 to changelog * Add #8979 to changelog * Add #8980 to changelog * Add #8982 to changelog * Add #8983 to changelog * Add #8984 to changelog * Add #8986 to changelog * Add #9005 to changelog * Add #9010 to changelog * Add #9012 to changelog * Add #9021 to changelog * Add #9022 to changelog * Add #9056 to changelog * Add #9061 to changelog * Add #9079 to changelog * Add #9080 to changelog * Add #9088 to changelog * Add #9096 to changelog * Add #9097 to changelog * Add #9100 to changelog * Add #9107 to changelog * Add #8969 to changelog * Add #8993 to changelog * Add #9003 to changelog * Add #9031 to changelog * Add #8945 to changelog * Add #9052 to changelog * Add #9058 to changelog * Add #9066 to changelog * Add #9076 to changelog * Add #9053 to changelog * Add #9108 to changelog * Add #9135 to changelog * Add #9148 to changelog * Add #9125 to changelog * Add #9137 to changelog * Added testing instructions for 6.0. * Added IS testing instructions, huge props to @tiagonoronha. * Added #8498 to changelog. * Added #8954 to changelog. * Added #8985 to changelog. * add #9027 * add #9112 to changelog * add #9136 to changelog * add #9102 to changelog * add #9093 to changelog * add #9062 to changelog * add #9172 to changelog

rickybanister · 2018-03-28T18:24:51Z

A few minor tweaks please:

Note the language changes, there are a few of them. I also moved the final paragraph above the setting so it was easier to see it. I also removed the end margin from the setting toggle as well as the period at the end of the label.

Text:

The Jetpack team is committed to your privacy and security.

Read about how Jetpack uses your data in the Automattic Privacy Policy and our "What Data Does Jetpack Sync?" document. You can also find more WordPress privacy information and resources on privacy.blog.

dereksmart added [Status] In Progress [Focus] GDPR labels Mar 6, 2018

dereksmart requested a review from a team as a code owner March 6, 2018 22:01

jeherve added this to the GDPR Compliant milestone Mar 7, 2018

ghost assigned eliorivero Mar 8, 2018

eliorivero force-pushed the add/privacy-page branch from 71b60ed to 805141f Compare March 8, 2018 16:31

eliorivero previously requested changes Mar 8, 2018

View reviewed changes

ghost removed the [Status] In Progress label Mar 9, 2018

eliorivero added the [Status] Needs Review This PR is ready for review. label Mar 9, 2018

dereksmart commented Mar 9, 2018

View reviewed changes

bperson mentioned this pull request Mar 14, 2018

Privacy settings: Add toggle for Tracks opt-out Automattic/wp-calypso#23231

Merged

rickybanister added the [Status] Needs Design Review Design has been added. Needs a review! label Mar 16, 2018

jaswrks reviewed Mar 16, 2018

View reviewed changes

jaswrks mentioned this pull request Mar 19, 2018

Implement setOptOut cookie command #9085

Closed

dereksmart added the [Pri] BLOCKER label Mar 23, 2018

eliorivero added 6 commits March 23, 2018 16:54

Add PropTypes and declare props. Combine selectors imported from the …

1e53b12

…same path. Introduce ModuleSettingsForm to use getOptionValue and isSavingAnyOption so ththe toggle now works. Simplify mapStateToProps and mapDispatchToProps. Simplify other minor code.

Combine sentence to save option with an existing one to avoid duplica…

31e654a

…ting code.

Add link to privacy policy plus placeholder text

b60967b

Add link to privacy blog

f12abe0

Update code to work with PR #9003 so we save this setting by user

1366fea

Update privacy texts and links.

6370bdc

dereksmart added [Status] Ready to Merge Go ahead, you can push that green button! and removed [Status] Needs Review This PR is ready for review. labels Mar 26, 2018

oskosk approved these changes Mar 26, 2018

View reviewed changes

zinigor approved these changes Mar 26, 2018

View reviewed changes

zinigor merged commit 4d6e28b into master Mar 26, 2018

matticbot added the [Status] Needs Changelog label Mar 26, 2018

zinigor deleted the add/privacy-page branch March 26, 2018 14:46

ghost removed the [Status] Ready to Merge Go ahead, you can push that green button! label Mar 26, 2018

simison mentioned this pull request Mar 26, 2018

Network Settings: secure footer links #9146

Merged

oskosk modified the milestones: GDPR Compliant, 6.0 Mar 26, 2018

oskosk added a commit that referenced this pull request Mar 26, 2018

Add #8993 to changelog

0abbc0a

oskosk added [Status] Has Changelog and removed [Status] Needs Changelog labels Mar 26, 2018

mattwiebe mentioned this pull request Mar 26, 2018

Privacy Settings: Fix PropTypes error #9153

Merged

jaswrks mentioned this pull request Mar 27, 2018

Redux ingestion for user tracking settings #9154

Merged

mattwiebe mentioned this pull request Mar 27, 2018

Privacy: use the wpcom API to centralize opt-out #9155

Closed

jaswrks mentioned this pull request Mar 27, 2018

Update/centralize user privacy + cookie (PR combo) #9156

Merged


		class Privacy extends React.Component {
		static displayName = 'PrivacySettings';

Add new settings route and page for Privacy settings #8993

Add new settings route and page for Privacy settings #8993

Uh oh!

Conversation

dereksmart commented Mar 6, 2018 • edited by oskosk Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Changelog entry

Uh oh!

eliorivero commented Mar 8, 2018 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

eliorivero commented Mar 8, 2018

Uh oh!

eliorivero commented Mar 8, 2018

Uh oh!

bubel commented Mar 8, 2018

Uh oh!

eliorivero commented Mar 9, 2018

Uh oh!

pesieminski commented Mar 9, 2018

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

pesieminski commented Mar 9, 2018

Uh oh!

eliorivero commented Mar 9, 2018

Uh oh!

bubel commented Mar 13, 2018

Uh oh!

bperson commented Mar 13, 2018

Uh oh!

Choose a reason for hiding this comment

Uh oh!

eliorivero Mar 16, 2018 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

jaswrks commented Mar 16, 2018

Uh oh!

bperson commented Mar 19, 2018

Uh oh!

jaswrks commented Mar 19, 2018

Uh oh!

jaswrks commented Mar 20, 2018

Uh oh!

eliorivero commented Mar 23, 2018

Uh oh!

dereksmart commented Mar 23, 2018 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

dereksmart commented Mar 23, 2018 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

dereksmart commented Mar 26, 2018

dereksmart commented Mar 6, 2018 •

edited by oskosk

Loading

eliorivero commented Mar 8, 2018 •

edited

Loading

eliorivero Mar 16, 2018 •

edited

Loading

dereksmart commented Mar 23, 2018 •

edited

Loading

dereksmart commented Mar 23, 2018 •

edited

Loading