Commit change to module-headings.php #8981
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The Jumpstart description was removed a few days ago in #8938 but the built file was not commited, so this keeps showing up as a changed file whenever you run `npm run build` locally.
withinboredom
approved these changes
Mar 5, 2018
Contributor
withinboredom
left a comment
withinboredom
left a comment
There was a problem hiding this comment.
Will merge as soon as it passes
withinboredom
added
[Status] Ready to Merge
Contributor
|
I wondered why that file kept showing up as modified! I was thinking |
kraftbj
removed
the
[Status] Ready to Merge
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Minor Problem
Upon running
npm run buildfrom the master branch, themodules/module-headings.phpfile keeps showing up as a changed file, even though I didn't change anything in this file.Reason
The Jumpstart description was removed a few days ago in #8938 but the built file was not committed with it at that time.
Solution
I ran
npm run buildto generate the newmodules/module-headings.phpfile.