Skip to content

Conversation

@keoshi
Copy link
Contributor

@keoshi keoshi commented Mar 5, 2018

This PR forces words to break on long usernames and email addresses in the account connection settings in the dashboard.

Before

image

After

image

Fixes #8779

Proposed changelog entry for your changes:

Fixes Dashboard connection card from showing text that overflows the card.

@keoshi keoshi requested a review from a team as a code owner March 5, 2018 13:45
@keoshi keoshi added [Status] Needs Review This PR is ready for review. Admin Page React-powered dashboard under the Jetpack menu [Pri] Normal [Focus] FixTheFlows labels Mar 5, 2018
@designsimply
Copy link

designsimply commented Mar 6, 2018

Whoops. I posted in the wrong issue. Fixing. 😊

Copy link
Contributor

@gravityrail gravityrail left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🎉

@gravityrail gravityrail added [Status] Ready to Merge Go ahead, you can push that green button! and removed [Status] Needs Review This PR is ready for review. labels Mar 7, 2018
@gravityrail gravityrail merged commit 8dc28d3 into master Mar 7, 2018
@gravityrail gravityrail deleted the fix/connection-settings-overflow-text branch March 7, 2018 23:34
@oskosk oskosk added this to the 6.0 milestone Mar 9, 2018
oskosk added a commit that referenced this pull request Mar 16, 2018
dereksmart pushed a commit that referenced this pull request Mar 27, 2018
* Changelog 6.0: create base for changelog.

* Add #8938 to changelog

* Add #8962 to changelog

* Add #8974 to changelog

* Add #8975 to changelog

* Add #8978 to changelog

* Add #8867 to changelog

* Add #8937 to changelog

* Add #8961 to changelog

* Add #8855 to changelog

* Add #8944 to changelog

* Add #8973 to changelog

* Add #8977 to changelog

* Add #8979 to changelog

* Add #8980 to changelog

* Add #8982 to changelog

* Add #8983 to changelog

* Add #8984 to changelog

* Add #8986 to changelog

* Add #9005 to changelog

* Add #9010 to changelog

* Add #9012 to changelog

* Add #9021 to changelog

* Add #9022 to changelog

* Add #9056 to changelog

* Add #9061 to changelog

* Add #9079 to changelog

* Add #9080 to changelog

* Add #9088 to changelog

* Add #9096 to changelog

* Add #9097 to changelog

* Add #9100 to changelog

* Add #9107 to changelog

* Add #8969 to changelog

* Add #8993 to changelog

* Add #9003 to changelog

* Add #9031 to changelog

* Add #8945 to changelog

* Add #9052 to changelog

* Add #9058 to changelog

* Add #9066 to changelog

* Add #9076 to changelog

* Add #9053 to changelog

* Add #9108 to changelog

* Add #9135 to changelog

* Add #9148 to changelog

* Add #9125 to changelog

* Add #9137 to changelog

* Added testing instructions for 6.0.

* Added IS testing instructions, huge props to @tiagonoronha.

* Added #8498 to changelog.

* Added #8954 to changelog.

* Added #8985 to changelog.

* add #9027

* add #9112 to changelog

* add #9136 to changelog

* add #9102 to changelog

* add #9093 to changelog

* add #9062 to changelog

* add #9172 to changelog
@kraftbj kraftbj removed the [Status] Ready to Merge Go ahead, you can push that green button! label Oct 13, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Admin Page React-powered dashboard under the Jetpack menu [Focus] FixTheFlows [Pri] Normal

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Dashboard: overflowing long text in Connection -boxes

7 participants