Admin Page Fix all eslint warnings about the react/jsx-no-bind rule #8867
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
oskosk
added
[Status] In Progress
Admin Page
Contributor
Author
|
Note that this rule is trying to warn the problem that arises when functions are created on the fly while rendering. The current fixes remove the warnings by not binding inline and by not defining arrow functions among jsx, but in some cases we're still creating functions on the fly. Will try to update to no create functions where possible. |
oskosk
force-pushed
the
remove/bind-pattern
branch
2 times, most recently
from
8dc870d to
f97546c
Compare
oskosk
added
[Status] Needs Review
Contributor
Author
|
I've updated some commits to remove the wrong pattern where it made sense. |
oskosk
force-pushed
the
remove/bind-pattern
branch
from
f97546c to
1879604
Compare
oskosk
force-pushed
the
remove/bind-pattern
branch
from
1879604 to
de03440
Compare
oskosk
force-pushed
the
remove/bind-pattern
branch
from
de03440 to
728e6ee
Compare
dereksmart
approved these changes
Mar 13, 2018
Contributor
dereksmart
left a comment
dereksmart
left a comment
There was a problem hiding this comment.
No problems from fresh build. Let's get this in
dereksmart
added
[Status] Ready to Merge
Contributor
Author
|
Thank you! |
ghost
removed
the
[Status] Ready to Merge
dereksmart
pushed a commit
that referenced
this pull request
Mar 27, 2018
* Changelog 6.0: create base for changelog. * Add #8938 to changelog * Add #8962 to changelog * Add #8974 to changelog * Add #8975 to changelog * Add #8978 to changelog * Add #8867 to changelog * Add #8937 to changelog * Add #8961 to changelog * Add #8855 to changelog * Add #8944 to changelog * Add #8973 to changelog * Add #8977 to changelog * Add #8979 to changelog * Add #8980 to changelog * Add #8982 to changelog * Add #8983 to changelog * Add #8984 to changelog * Add #8986 to changelog * Add #9005 to changelog * Add #9010 to changelog * Add #9012 to changelog * Add #9021 to changelog * Add #9022 to changelog * Add #9056 to changelog * Add #9061 to changelog * Add #9079 to changelog * Add #9080 to changelog * Add #9088 to changelog * Add #9096 to changelog * Add #9097 to changelog * Add #9100 to changelog * Add #9107 to changelog * Add #8969 to changelog * Add #8993 to changelog * Add #9003 to changelog * Add #9031 to changelog * Add #8945 to changelog * Add #9052 to changelog * Add #9058 to changelog * Add #9066 to changelog * Add #9076 to changelog * Add #9053 to changelog * Add #9108 to changelog * Add #9135 to changelog * Add #9148 to changelog * Add #9125 to changelog * Add #9137 to changelog * Added testing instructions for 6.0. * Added IS testing instructions, huge props to @tiagonoronha. * Added #8498 to changelog. * Added #8954 to changelog. * Added #8985 to changelog. * add #9027 * add #9112 to changelog * add #9136 to changelog * add #9102 to changelog * add #9093 to changelog * add #9062 to changelog * add #9172 to changelog
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes all eslint warnings about the react/jsx-no-bind rule.
Changes proposed in this Pull Request:
react/jsx-no-bind ruleto an error..bind()andonEvent={ () => {} }patterns among jsx code.Testing instructions:
npm run lintand expect to see no linting warnings.yarn build).Proposed changelog entry for your changes: