Allow enabling lazy images from the upgrade screen #8700
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gravityrail
added
[Status] Needs Review
Contributor
|
I love adding it as an interactive element! As I mention in Slack, I think it might be good to incklude the whole setting including description. At the very least it will look like an image of where it is and if they try to interact with it, magic! |
dereksmart
approved these changes
Feb 1, 2018
Contributor
dereksmart
left a comment
dereksmart
left a comment
There was a problem hiding this comment.
LGTM -- pushed a couple commits to fix eslint errors and console warnings
dereksmart
added
[Status] Ready to Merge
Contributor
Author
|
Since it's approved in its current state, I am going to merge this and add the description in a separate PR. |
gravityrail
removed
the
[Status] Ready to Merge
jeherve
pushed a commit
that referenced
this pull request
Feb 2, 2018
* Allow enabling lazy images from the upgrade screen * Style tweaks * Add 8px padding to bottom of settings * fix eslint -- remove unused * fix console warnings nested div in p
Member
|
cherry-picked to |
This was referenced Feb 23, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
A suggestion from @beaulebens, it's handy for users to be able to enable a new feature when we add a UI for it.
So I added the module toggle right into the upgrade notice.
Testing instructions:
data-lazy-loaded="1"attribute)Proposed changelog entry for your changes:
Allow enabling new features from upgrade screen