Skip to content

Conversation

@donnchawp
Copy link
Contributor

WP CLI loads WordPress through a function and the global variables used by WP Super Cache have to be declared global. We did this with most variables, but it was reported one was missing.
I added many more in this PR.

Proposed changes:

  • Add global variables to wp-cache.php

Other information:

  • Have you written new tests for your changes, if applicable?
  • Have you checked the E2E test CI results, and verified that your changes do not break them?
  • Have you tested your changes on WordPress.com, if applicable (if so, you'll see a generated comment below with a script to run)?

Jetpack product discussion

Does this pull request change what data or activity we track or use?

Testing instructions:

  • Apply PR
  • Test WP CLI code that interact with the cache.

@donnchawp donnchawp self-assigned this Apr 29, 2025
@donnchawp donnchawp added [Type] Bug When a feature is broken and / or not performing as intended [Status] In Progress [Plugin] Super Cache A fast caching plugin for WordPress. labels Apr 29, 2025
@github-actions
Copy link
Contributor

Thank you for your PR!

When contributing to Jetpack, we have a few suggestions that can help us test and review your patch:

  • ✅ Include a description of your PR changes.
  • ✅ Add a "[Status]" label (In Progress, Needs Review, ...).
  • ✅ Add a "[Type]" label (Bug, Enhancement, Janitorial, Task).
  • ✅ Add testing instructions.
  • ✅ Specify whether this PR includes any changes to data or privacy.
  • ✅ Add changelog entries to affected projects

This comment will be updated as you work on your PR and make changes. If you think that some of those checks are not needed for your PR, please explain why you think so. Thanks for cooperation 🤖


Follow this PR Review Process:

  1. Ensure all required checks appearing at the bottom of this PR are passing.
  2. Make sure to test your changes on all platforms that it applies to. You're responsible for the quality of the code you ship.
  3. You can use GitHub's Reviewers functionality to request a review.
  4. When it's reviewed and merged, you will be pinged in Slack to deploy the changes to WordPress.com simple once the build is done.

If you have questions about anything, reach out in #jetpack-developers for guidance!


Super Cache plugin:

No scheduled milestone found for this plugin.

If you have any questions about the release process, please ask in the #jetpack-releases channel on Slack.

@jp-launch-control
Copy link

jp-launch-control bot commented Apr 29, 2025

Code Coverage Summary

Coverage changed in 1 file.

File Coverage Δ% Δ Uncovered
projects/plugins/super-cache/wp-cache.php 0/2642 (0.00%) 0.00% 9 💔

Full summary · PHP report

Coverage check overridden by Coverage tests to be added later Use to ignore the Code coverage requirement check when tests will be added in a follow-up PR .

@donnchawp donnchawp added the Coverage tests to be added later Use to ignore the Code coverage requirement check when tests will be added in a follow-up PR label Apr 29, 2025
@donnchawp donnchawp requested a review from a team May 7, 2025 08:50
@donnchawp donnchawp added [Status] Needs Review This PR is ready for review. and removed [Status] In Progress labels May 7, 2025
@donnchawp donnchawp merged commit 3801b54 into trunk May 7, 2025
71 checks passed
@donnchawp donnchawp deleted the fix/super-cache/wp-cli-global-variables branch May 7, 2025 09:24
@github-actions github-actions bot added this to the super-cache/1.12.5 milestone May 7, 2025
@github-actions github-actions bot removed the [Status] Needs Review This PR is ready for review. label May 7, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Coverage tests to be added later Use to ignore the Code coverage requirement check when tests will be added in a follow-up PR [Plugin] Super Cache A fast caching plugin for WordPress. [Type] Bug When a feature is broken and / or not performing as intended

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants