Skip to content

Admin Page: add toggle to activate new Google Fonts feature #23295

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
jeherve merged 7 commits into from
Mar 10, 2022
Merged

Admin Page: add toggle to activate new Google Fonts feature #23295

jeherve merged 7 commits into from
Mar 10, 2022

Conversation

@jeherve
Copy link
Member

@jeherve jeherve commented Mar 8, 2022

Follow-up to #23045

Changes proposed in this Pull Request:

This adds:

  • a new check to the initial state passed by PHP, to indicate whether a site can use the webfonts feature.
  • a new interface under Jetpack > Settings > Writing.

Jetpack product discussion

  • paYE8P-1qo-p2

Does this pull request change what data or activity we track or use?

  • No

Testing instructions:

  • Start with a site where you have activated the Twenty Twenty Two theme.
  • Install a development version of the Gutenberg theme (with latest trunk)
  • Go to Jetpack > Settings > Writing and scroll down to Theme enhancements
    • You'll want to test other variations as well, when using another, non-block theme, or when not using the Gutenberg; the interface should not appear then.
  • Ensure you can turn the feature on and off.
  • Ensure the links work (the support doc is still a draft, so you will get a 404 on jetpack.com).

@jeherve
Admin Page: add toggle to activate new Google Fonts feature
991cc92 
Follow-up to #23045

This adds:

- a new check to the initial state passed by PHP, to indicate whether a site can use the webfonts feature.
- a new interface under Jetpack > Settings > Writing.
@jeherve jeherve added this to the jetpack/10.8 milestone Mar 8, 2022
@jeherve jeherve added Admin Page React-powered dashboard under the Jetpack menu [Package] Google Fonts Provider This package no longer exists in the monorepo. [Pri] Normal [Status] Needs Review This PR is ready for review. [Type] Enhancement Changes to an existing feature — removing, adding, or changing parts of it labels Mar 8, 2022
@jeherve jeherve self-assigned this Mar 8, 2022
@jeherve jeherve requested a review from creativecoder March 8, 2022 15:32
@jeherve jeherve mentioned this pull request Mar 8, 2022
Merged
jeherve
jeherve commented Mar 8, 2022
View reviewed changes
projects/plugins/jetpack/_inc/client/components/settings-card/test/component.js
'json-api',
'photon'
'photon',
'google-fonts',
Copy link
Member Author

@jeherve jeherve Mar 8, 2022

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is the only relevant change, the rest is done by Prettier.

jeherve
jeherve commented Mar 8, 2022
View reviewed changes
projects/plugins/jetpack/_inc/client/components/settings-group/test/component.js
'json-api',
'photon'
'photon',
'google-fonts',
Copy link
Member Author

@jeherve jeherve Mar 8, 2022

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is the only relevant change, the rest is done by Prettier.

@github-actions github-actions bot added the [Plugin] Jetpack Issues about the Jetpack plugin. https://wordpress.org/plugins/jetpack/ label Mar 8, 2022
@github-actions
Copy link
Contributor

github-actions bot commented Mar 8, 2022 •
edited
Loading

Thank you for your PR!

When contributing to Jetpack, we have a few suggestions that can help us test and review your patch:

  • ✅ Include a description of your PR changes.
  • ✅ All commits were linted before commit.
  • ✅ Add a "[Status]" label (In Progress, Needs Team Review, ...).
  • ✅ Add testing instructions.
  • ✅ Specify whether this PR includes any changes to data or privacy.
  • ✅ Add changelog entries to affected projects

This comment will be updated as you work on your PR and make changes. If you think that some of those checks are not needed for your PR, please explain why you think so. Thanks for cooperation 🤖

The e2e test report can be found here. Please note that it can take a few minutes after the e2e tests checks are complete for the report to be available.

Once your PR is ready for review, check one last time that all required checks (other than "Required review") appearing at the bottom of this PR are passing or skipped.
Then, add the "[Status] Needs Team review" label and ask someone from your team review the code.
Once you’ve done so, switch to the "[Status] Needs Review" label; someone from Jetpack Crew will then review this PR and merge it to be included in the next Jetpack release.

Jetpack plugin:

  • Next scheduled release: April 5, 2022.
  • Scheduled code freeze: March 29, 2022.

creativecoder
creativecoder reviewed Mar 8, 2022
View reviewed changes
Copy link
Contributor

@creativecoder creativecoder left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Works well!

✅ Toggle in Settings > Theme enhancements turns module off/on
✅ Toggle is not shown when theme doesn't support the module
✅ Module setting persists after switching themes that do/do not support the module

I left one suggestion, other wise this looks good.

@samiff samiff added [Status] Needs Author Reply We need more details from you. This label will be auto-added until the PR meets all requirements. and removed [Status] Needs Review This PR is ready for review. labels Mar 8, 2022
@jeherve jeherve added [Status] Needs Review This PR is ready for review. and removed [Status] Needs Author Reply We need more details from you. This label will be auto-added until the PR meets all requirements. labels Mar 9, 2022
@jeherve jeherve enabled auto-merge (squash) March 9, 2022 09:15
creativecoder
creativecoder previously approved these changes Mar 9, 2022
View reviewed changes
@samiff samiff self-requested a review March 10, 2022 21:59
samiff
samiff approved these changes Mar 10, 2022
View reviewed changes
Copy link
Contributor

@samiff samiff left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The toggle worked well for me 👍

@jeherve jeherve merged commit 51efe46 into master Mar 10, 2022
@jeherve jeherve deleted the add/settings-google-fonts branch March 10, 2022 23:57
@github-actions github-actions bot removed the [Status] Needs Review This PR is ready for review. label Mar 10, 2022
jeherve added a commit that referenced this pull request Mar 30, 2022
@jeherve
Google Fonts: mark feature as Beta and remove from dashboard.
33c232a 
Follow-up from #23295

The feature is still under development, and we'll need to make some more changes before it's ready for prime-time. Let's make that clear in the plugin by marking the module as beta and removing the toggle from the dashboard to avoid setting wrong expectations.

Internal reference: p1HpG7-flD-p2#comment-53417
@jeherve jeherve mentioned this pull request Mar 30, 2022
Merged
samiff pushed a commit that referenced this pull request Mar 30, 2022
@jeherve
Google Fonts: mark feature as Beta and remove from dashboard. (#23713)
879b1d7 
Follow-up from #23295

The feature is still under development, and we'll need to make some more changes before it's ready for prime-time. Let's make that clear in the plugin by marking the module as beta and removing the toggle from the dashboard to avoid setting wrong expectations.

Internal reference: p1HpG7-flD-p2#comment-53417
samiff pushed a commit that referenced this pull request Mar 30, 2022
@jeherve @samiff
[not verified] Google Fonts: mark feature as Beta and remove from das…
92df9b4 
…hboard. (#23713)

Follow-up from #23295

The feature is still under development, and we'll need to make some more changes before it's ready for prime-time. Let's make that clear in the plugin by marking the module as beta and removing the toggle from the dashboard to avoid setting wrong expectations.

Internal reference: p1HpG7-flD-p2#comment-53417
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

2 more reviewers

@samiff samiff samiff approved these changes

@creativecoder creativecoder creativecoder left review comments

Reviewers whose approvals may not affect merge requirements

Assignees

@jeherve jeherve

Labels

Admin Page React-powered dashboard under the Jetpack menu [Package] Google Fonts Provider This package no longer exists in the monorepo. [Plugin] Jetpack Issues about the Jetpack plugin. https://wordpress.org/plugins/jetpack/ [Pri] Normal [Type] Enhancement Changes to an existing feature — removing, adding, or changing parts of it

Projects

None yet

Milestone

jetpack/10.8

Development

Successfully merging this pull request may close these issues.

4 participants

@jeherve @creativecoder @samiff