Skip to content

My Jetpack: Disable browser cache for My Jetpack #23146

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
leogermani merged 2 commits into from
Feb 28, 2022
Merged

My Jetpack: Disable browser cache for My Jetpack #23146

leogermani merged 2 commits into from
Feb 28, 2022

Conversation

@leogermani
Copy link
Contributor

@leogermani leogermani commented Feb 28, 2022

Changes proposed in this Pull Request:

  • Disable browser cache for My Jetpack

Jetpack product discussion

N/A

Does this pull request change what data or activity we track or use?

No

Testing instructions:

  • Apply this branch
  • Go to My Jetpack
  • Refresh the window a couple of times to make sure new headers are read by the browser
  • Open a new tab and go to Plugins
  • Activate (or Deactivate) Akismet
  • Go to the tab that is open in My Jetpack
  • Navigate to any other page in wp-admin
  • Hit the "back" button in the browser
  • Verify that the "Anti Spam" card reflects the new state

Run the same test in the master branch and confirm that when you go back to My Jetpack, the Anti spam product card still shows the old state.
*

@leogermani leogermani added the [Status] Needs Review This PR is ready for review. label Feb 28, 2022
@leogermani leogermani self-assigned this Feb 28, 2022
@github-actions
Copy link
Contributor

github-actions bot commented Feb 28, 2022 •
edited
Loading

Thank you for your PR!

When contributing to Jetpack, we have a few suggestions that can help us test and review your patch:

  • ✅ Include a description of your PR changes.
  • ✅ All commits were linted before commit.
  • ✅ Add a "[Status]" label (In Progress, Needs Team Review, ...).
  • ✅ Add testing instructions.
  • ✅ Specify whether this PR includes any changes to data or privacy.
  • ✅ Add changelog entries to affected projects

This comment will be updated as you work on your PR and make changes. If you think that some of those checks are not needed for your PR, please explain why you think so. Thanks for cooperation 🤖

The e2e test report can be found here. Please note that it can take a few minutes after the e2e tests checks are complete for the report to be available.

Once your PR is ready for review, check one last time that all required checks (other than "Required review") appearing at the bottom of this PR are passing or skipped.
Then, add the "[Status] Needs Team review" label and ask someone from your team review the code.
Once you’ve done so, switch to the "[Status] Needs Review" label; someone from Jetpack Crew will then review this PR and merge it to be included in the next Jetpack release.

@oskosk oskosk added this to the My Jetpack 1.0 milestone Feb 28, 2022
@oskosk oskosk added [Status] Ready to Merge Go ahead, you can push that green button! and removed [Status] Needs Review This PR is ready for review. labels Feb 28, 2022
oskosk
oskosk approved these changes Feb 28, 2022
View reviewed changes
Copy link
Contributor

@oskosk oskosk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Like a charm!

@leogermani leogermani enabled auto-merge (squash) February 28, 2022 21:07
@leogermani leogermani merged commit bd8307b into master Feb 28, 2022
@leogermani leogermani deleted the fix/my-jetapack-browser-cache branch February 28, 2022 21:16
@github-actions github-actions bot removed the [Status] Ready to Merge Go ahead, you can push that green button! label Feb 28, 2022
@westonruter westonruter mentioned this pull request Jul 16, 2025
Merged
3 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

1 more reviewer

@oskosk oskosk oskosk approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

@leogermani leogermani

Labels

[Package] My Jetpack

Projects

None yet

Milestone

My Jetpack 1.0

Development

Successfully merging this pull request may close these issues.

3 participants

@leogermani @oskosk