Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Publicize: update connection confirmation message #1476

Merged
merged 3 commits into from
Jan 12, 2015

Conversation

@jeherve jeherve added [Feature] Publicize Now Jetpack Social, auto-sharing Team Partnerships [Type] Enhancement Changes to an existing feature — removing, adding, or changing parts of it labels Jan 5, 2015
@jeherve jeherve modified the milestones: vFuture, Publicize Next Jan 5, 2015
@jkudish jkudish self-assigned this Jan 7, 2015
@jkudish
Copy link
Contributor

jkudish commented Jan 7, 2015

This file is synced verbatim with WP.com so we'd need some kind of conditional in there to make sure the string only appears in the right context.

@jeherve
Copy link
Member Author

jeherve commented Jan 7, 2015

@jkudish I updated my PR according to your comment. Is that what you had in mind?

samhotchkiss added a commit that referenced this pull request Jan 12, 2015
Publicize: update connection confirmation message
@samhotchkiss samhotchkiss merged commit 54fef74 into Automattic:master Jan 12, 2015
@samhotchkiss
Copy link
Contributor

This looks good, I merged and closed, @jkudish, can you take a peek when you get a chance to make sure I didn't just break everything?

@jeherve jeherve deleted the update/publicize-message branch July 21, 2015 12:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
[Feature] Publicize Now Jetpack Social, auto-sharing [Type] Enhancement Changes to an existing feature — removing, adding, or changing parts of it
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants