-
Notifications
You must be signed in to change notification settings - Fork 843
Description
Synopsis: Core has merged in Custom CSS to the Customizer using a different CPT. Let's redo our implementation to enhance the Core version.
Responsible: @georgestephanis
User experience: User experience should be roughly similar to the existing Jetpack UX, but using the underlying Core data structure.
Core Ticket for reference: https://core.trac.wordpress.org/ticket/38672
Technical approach:
Transition our data over to Core’s data structure, and let Core do the heavy lifting. Change Jetpack’s implementation to just layering stuff like LESS, Sass, Syntax Highlighting, CSSTidy, Revisions on top of Core’s existing implementation.
We would also need to change the permission check for the Core Custom CSS Editor to allow non-Superadmins on a multisite install (like WordCamp.org) to edit CSS — basically remap it to edit_theme_options.
This would have some interesting implications, but the general gist is that without Jetpack Custom CSS, permissions simply revert to superadmins only. If we choose to respect the initial cap for unfiltered_css there could be some problems if a superadmin modifies the css, it saves unfiltered, then a Regular admin edits it and strips out the changes.
Designs: Unsure how many (if any) are needed. Mirroring existing Jetpack and WPCOM ui.
Complete: 100%
Difficulty: 15/40
Last Updated: 11/7 by @georgestephanis