Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Jetpack: Deleting Jetpack plugin breaks the Jetpack connection on standalone plugins #28540

Closed
dhasilva opened this issue Jan 23, 2023 · 6 comments
Closed

Jetpack: Deleting Jetpack plugin breaks the Jetpack connection on standalone plugins #28540

dhasilva opened this issue Jan 23, 2023 · 6 comments
Assignees
@sergeymitr
Labels
[Package] Connection [Plugin] Jetpack Issues about the Jetpack plugin. https://wordpress.org/plugins/jetpack/ [Pri] Normal [Status] Auto-allocated [Type] Bug When a feature is broken and / or not performing as intended

Comments

@dhasilva
Copy link
Contributor

Steps to reproduce:

1 - With Jetpack and VideoPress installed, connect the site
2 - Deactivate and delete the Jetpack plugin
3 - Check that the connection is broken, even though we still have the VideoPress plugin installed

p1674497316761689/1674497281.387129-slack-C03TA48NSUX

PS: This could potentially be happening to other plugins as well
@dhasilva dhasilva added [Feature] VideoPress A feature to help you upload and insert videos on your site. [Plugin] Jetpack Issues about the Jetpack plugin. https://wordpress.org/plugins/jetpack/ [Plugin] VideoPress A standalone plugin to add high-quality VideoPress videos to your site. labels Jan 23, 2023
@dhasilva dhasilva added this to the videopress/1.4.0 milestone Jan 23, 2023
@nunyvega
Copy link

Not specific to VideoPress:
I tested it on a site with VaultPress Backup active and connected and Jetpack installed but deactivated, when I delete Jetpack it disconnects the Backup plugin too.

@dhasilva dhasilva added [Type] Bug When a feature is broken and / or not performing as intended and removed [Feature] VideoPress A feature to help you upload and insert videos on your site. [Plugin] VideoPress A standalone plugin to add high-quality VideoPress videos to your site. labels Jan 23, 2023
@jeherve
Copy link
Member

jeherve commented Jan 24, 2023

I believe @leogermani could tell you more about this, but I think this may be done on purpose.

For reference, here are some past discussions about this:

  • p9dueE-4n9-p2
  • p9dueE-55t-p2

@leogermani
Copy link
Contributor

If I recall correctly this was the behavior before https://github.com/Automattic/jetpack/pull/23957/files

So the expected behavior now was for the connection to be kept alive if other plugins are using it. So it may be a regression.

cc @sergeymitr who followed this closely as well.

@retrofox retrofox removed this from the videopress/1.4.0 milestone Feb 2, 2023
@jeherve jeherve mentioned this issue Apr 26, 2023
Closed
@jeherve
Copy link
Member

jeherve commented Apr 26, 2023

This was also reported in #30243, for WooCommerce Payments

@dhasilva dhasilva changed the title VideoPress: Deleting Jetpack plugin breaks the Jetpack connection Jetpack: Deleting Jetpack plugin breaks the Jetpack connection on standalone plugins Apr 26, 2023
@jeherve jeherve mentioned this issue May 1, 2023
Closed
@fgiannar
Copy link
Contributor

I believe this was fixed by @sergeymitr back in Nov, 2023 via #33920

Sergey, can you pls confirm so that we can close this one?

@jeherve jeherve added [Status] Needs Author Reply We need more details from you. This label will be auto-added until the PR meets all requirements. [Pri] Normal [Package] Connection labels Jan 20, 2025
@jartes jartes moved this from Needs Triage to Triaged in Automattic Prioritization: The One Board ™ Jan 20, 2025
@sergeymitr sergeymitr self-assigned this Jan 21, 2025
@sergeymitr
Copy link
Contributor

Thanks for the ping @fgiannar.
I double checked, and it is indeed fixed.

@github-actions github-actions bot removed the [Status] Needs Author Reply We need more details from you. This label will be auto-added until the PR meets all requirements. label Jan 21, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@sergeymitr sergeymitr

Labels
[Package] Connection [Plugin] Jetpack Issues about the Jetpack plugin. https://wordpress.org/plugins/jetpack/ [Pri] Normal [Status] Auto-allocated [Type] Bug When a feature is broken and / or not performing as intended
Projects
Automattic Prioritization: The One Board ™
Archived in project
Milestone
No milestone
Development

No branches or pull requests
8 participants
@retrofox @jeherve @leogermani @sergeymitr @fgiannar @dhasilva @nunyvega @matticbot