Various changes to improve behavior #1
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This prevents autofocus parameters from being dropped among other parameters
Contributor
|
Thanks for having a look. I talked to @melchoyce about some of this and we definitely agree that the flow is too fragile. The current state was mostly about getting something in play and then evaluating. This is an interesting approach that I would never have thought of. Very interesting. Probably a bit more heavy-handed than I'm comfortable with, which is why the next iteration is going to have a persistent, dismissible notice across wp-admin to go back to the Customizer. All links to the Customizer will take you back to the changeset you left off on until either 1) the notice is dismissed or 2) the changeset is published. We'll see if that feels better. ¯_(ツ)_/¯ |
Contributor
|
(Oh, and lots of useful stuff for me to lift here, thanks!) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Key changes:
sessionStoragecould be used to store thecustomizer_returnand injected in more places via JS.cursor:progressonce clicking link in preview to show while pending changes are written to changeset.