Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Disable opening edit_post_link in new window if Customize Posts plugin is active #22

Closed
westonruter opened this issue Aug 22, 2016 · 1 comment

Comments

@westonruter
Copy link
Contributor

The Customize Posts adds post editing into the customizer. It includes an integration so that when the edit post link is clicked in the preview, it will load the customizer section for that post and expand it so that it can be edited, directly in the customizer.

Here's an old demo video (from an early version) depicting this:

Demo of edit post link click

All of this to say, if the Customize Posts feature plugin is active, then the opening of edit post links in a new window behavior in the DM plugin should be disabled.

@sirbrillig
Copy link
Member

That's probably a good idea.

Also, this repo contains a disabled feature which adds blue DM buttons to each post: https://github.com/Automattic/customize-direct-manipulation/blob/master/src/modules/post-focus.js

The buttons link right now to the post editor.

We disabled it for launch because we weren't sure the feature would be helpful in its current form.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants