Skip to content

Comments

Wait until the page is loaded before loading Chatrix#160

Merged
akirk merged 1 commit intomainfrom
fix-loading-on-heavy-pages
Jan 23, 2023
Merged

Wait until the page is loaded before loading Chatrix#160
akirk merged 1 commit intomainfrom
fix-loading-on-heavy-pages

Conversation

@akirk
Copy link
Member

@akirk akirk commented Jan 23, 2023

Through trial and error I determined that on a heavier page like https://make.wordpress.org/polyglots/ the block is not loaded unless you make it load after the load event.

@akirk akirk requested a review from psrpinto January 23, 2023 14:24
Copy link
Member

@psrpinto psrpinto left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

For reference here's an article explaining the difference between the load and DOMContentLoaded events.

@psrpinto psrpinto added this to the 0.5 milestone Jan 23, 2023
@akirk akirk merged commit 7c68521 into main Jan 23, 2023
@akirk akirk deleted the fix-loading-on-heavy-pages branch January 23, 2023 14:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants