RestrictedFunctions: fix false negative - functions in config_settings would never match
#566
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jrfnl
force-pushed
the
fix/restricted-functions-opcache-config-settings-false-negative
branch
from
dd45ecd to
b61a257
Compare
…gs` would never match The functions in the `config_settings` group were using a unicode `_`, not the ascii `_`, so these would never match the PHP native `opcache_*` functions they were intended to match. As the same unicode character was used in the applicable unit tests and ruleset tests, the bug was never reported as a test failure.
GaryJones
approved these changes
Jul 28, 2020
Contributor
GaryJones
left a comment
GaryJones
left a comment
There was a problem hiding this comment.
Eeek - that's an amazing catch!
GaryJones
deleted the
fix/restricted-functions-opcache-config-settings-false-negative
branch
Contributor
|
Nice! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The functions in the
config_settingsgroup were using a unicode_, not the ascii_, so these would never match the PHP nativeopcache_*functions they were intended to match.As the same unicode character was used in the applicable unit tests and ruleset tests, the bug was never reported as a test failure.
Related to #518 (sniff review)