feat: improve template metadata -- skill taxonomy, descriptions, tags, and display names#752
feat: improve template metadata -- skill taxonomy, descriptions, tags, and display names#752
Conversation
Dependency Review✅ No vulnerabilities or license issues or OpenSSF Scorecard issues found.Scanned FilesNone |
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Repository UI Review profile: ASSERTIVE Plan: Pro Run ID: 📒 Files selected for processing (2)
📜 Recent review details⏰ Context from checks skipped due to timeout of 90000ms. You can increase the timeout in your CodeRabbit configuration to a maximum of 15 minutes (900000ms). (5)
🧰 Additional context used📓 Path-based instructions (2)**/*.py📄 CodeRabbit inference engine (CLAUDE.md)
Files:
tests/**/*.py📄 CodeRabbit inference engine (CLAUDE.md)
Files:
🧬 Code graph analysis (1)tests/unit/core/test_enums.py (1)
🔇 Additional comments (2)
WalkthroughAdded a SkillPattern taxonomy and exported enum with five members (tool_wrapper, generator, reviewer, inversion, pipeline). Template metadata was extended with 🚥 Pre-merge checks | ✅ 4 | ❌ 1❌ Failed checks (1 warning)
✅ Passed checks (4 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. Comment |
Summary of ChangesHello, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed! This pull request significantly enhances the metadata associated with company templates, providing richer and more structured information. By introducing a skill pattern taxonomy, updating descriptions, expanding tags, and clarifying display names, the changes aim to improve the discoverability, understanding, and classification of templates for users and internal systems. The modifications are propagated through the API and frontend, ensuring consistency across the platform and laying groundwork for more sophisticated template management. Highlights
Using Gemini Code AssistThe full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips. Invoking Gemini You can request assistance from Gemini at any point by creating a comment using either
Customization To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a Limitations & Feedback Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for GitHub and other Google products, sign up here. Footnotes
|
Aureliolo
temporarily deployed
to
cloudflare-preview
GitHub Actions
Inactive
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
There was a problem hiding this comment.
Actionable comments posted: 2
🤖 Prompt for all review comments with AI agents
Verify each finding against the current code and only fix it if needed.
Inline comments:
In `@src/synthorg/templates/builtins/dev_shop.yaml`:
- Around line 3-7: The YAML "description" field is too verbose; rewrite the
description in src/synthorg/templates/builtins/dev_shop.yaml to 2–3 sentences
only, preserving key facts (lean engineering team led by a Software Architect,
core roles: three backend developers, frontend specialist, QA pipeline, DevOps
engineer, and focus on throughput with quality gates). Replace the existing
multi-sentence paragraph under the description key with a concise 2–3 sentence
summary that bundles roles and purpose into one or two combined sentences and
ends with the optimization/quality intent.
- Line 2: The template's display name was changed to "Engineering Squad" but the
default metadata field company_name still reads "Dev Shop"; update the
company_name default in the YAML (and any other occurrences of "Dev Shop" in the
same template) to "Engineering Squad" so default metadata matches the name field
(check the name: "Engineering Squad" and company_name keys in the template and
make them consistent).
🪄 Autofix (Beta)
Fix all unresolved CodeRabbit comments on this PR:
- Push a commit to this branch (recommended)
- Create a new PR with the fixes
ℹ️ Review info
⚙️ Run configuration
Configuration used: Repository UI
Review profile: ASSERTIVE
Plan: Pro
Run ID: f1a93d82-b60b-43a4-8ac2-bd8c635f70b4
📒 Files selected for processing (20)
docs/design/communication.mddocs/design/operations.mddocs/design/organization.mdsrc/synthorg/api/controllers/setup.pysrc/synthorg/api/controllers/setup_models.pysrc/synthorg/core/__init__.pysrc/synthorg/core/enums.pysrc/synthorg/templates/builtins/agency.yamlsrc/synthorg/templates/builtins/dev_shop.yamlsrc/synthorg/templates/builtins/full_company.yamlsrc/synthorg/templates/builtins/product_team.yamlsrc/synthorg/templates/builtins/research_lab.yamlsrc/synthorg/templates/builtins/solo_founder.yamlsrc/synthorg/templates/builtins/startup.yamlsrc/synthorg/templates/loader.pysrc/synthorg/templates/schema.pytests/unit/api/controllers/test_setup.pytests/unit/templates/test_loader.pytests/unit/templates/test_schema.pyweb/src/api/types.ts
📜 Review details
⏰ Context from checks skipped due to timeout of 90000ms. You can increase the timeout in your CodeRabbit configuration to a maximum of 15 minutes (900000ms). (5)
- GitHub Check: Test (Python 3.14)
- GitHub Check: Build Web
- GitHub Check: Build Sandbox
- GitHub Check: Build Backend
- GitHub Check: Analyze (python)
🧰 Additional context used
📓 Path-based instructions (4)
**/*.py
📄 CodeRabbit inference engine (CLAUDE.md)
**/*.py: Nofrom __future__ import annotations-- Python 3.14 has PEP 649 native lazy annotations.
Use PEP 758 except syntax:except A, B:(no parentheses) -- ruff enforces this on Python 3.14.
Type hints: all public functions, mypy strict mode.
Docstrings: Google style, required on public classes/functions (enforced by ruff D rules).
Immutability: create new objects, never mutate existing ones. For non-Pydantic internal collections, usecopy.deepcopy()at construction +MappingProxyTypewrapping for read-only enforcement. Fordict/listfields in frozen Pydantic models, rely onfrozen=Trueandcopy.deepcopy()at system boundaries.
Config vs runtime state: frozen Pydantic models for config/identity; separate mutable-via-copy models for runtime state that evolves. Never mix static config fields with mutable runtime fields.
Models: Pydantic v2 (BaseModel,model_validator,computed_field,ConfigDict). Use@computed_fieldfor derived values. UseNotBlankStrfor all identifier/name fields instead of manual whitespace validators.
Async concurrency: preferasyncio.TaskGroupfor fan-out/fan-in parallel operations in new code. Prefer structured concurrency over barecreate_task.
Line length: 88 characters (ruff).
Functions: < 50 lines, files < 800 lines.
Errors: handle explicitly, never silently swallow.
Validate: at system boundaries (user input, external APIs, config files).
Variable name: alwayslogger(not_logger, notlog).
Files:
tests/unit/api/controllers/test_setup.pysrc/synthorg/core/__init__.pysrc/synthorg/api/controllers/setup.pysrc/synthorg/core/enums.pytests/unit/templates/test_schema.pysrc/synthorg/templates/loader.pysrc/synthorg/templates/schema.pysrc/synthorg/api/controllers/setup_models.pytests/unit/templates/test_loader.py
tests/**/*.py
📄 CodeRabbit inference engine (CLAUDE.md)
tests/**/*.py: Markers:@pytest.mark.unit,@pytest.mark.integration,@pytest.mark.e2e,@pytest.mark.slow
Parametrize: Prefer@pytest.mark.parametrizefor testing similar cases.
Tests must usetest-provider,test-small-001, etc. for vendor-agnostic test code.
Property-based testing: Python uses Hypothesis (@given+@settings). Hypothesis profiles:ci(50 examples, default) anddev(1000 examples), controlled viaHYPOTHESIS_PROFILEenv var.
Flaky tests: NEVER skip, dismiss, or ignore -- always fix them fully and fundamentally. For timing-sensitive tests, mocktime.monotonic()andasyncio.sleep()to make them deterministic. For tasks that must block indefinitely until cancelled, useasyncio.Event().wait()instead ofasyncio.sleep(large_number).
Files:
tests/unit/api/controllers/test_setup.pytests/unit/templates/test_schema.pytests/unit/templates/test_loader.py
src/synthorg/**/*.py
📄 CodeRabbit inference engine (CLAUDE.md)
src/synthorg/**/*.py: Every module with business logic MUST have:from synthorg.observability import get_loggerthenlogger = get_logger(__name__)
Event names: always use constants from domain-specific modules undersynthorg.observability.events(e.g.,API_REQUEST_STARTEDfromevents.api). Import directly:from synthorg.observability.events.<domain> import EVENT_CONSTANT
Structured kwargs: alwayslogger.info(EVENT, key=value)-- neverlogger.info("msg %s", val)
All error paths must log at WARNING or ERROR with context before raising.
All state transitions must log at INFO.
DEBUG for object creation, internal flow, entry/exit of key functions.
Vendor-agnostic everywhere: NEVER use real vendor names (Anthropic, OpenAI, Claude, GPT, etc.) in project-owned code, docstrings, comments, tests, or config examples. Use generic names:example-provider,example-large-001,example-medium-001,example-small-001,large/medium/smallas aliases.
Pure data models, enums, and re-exports do NOT need logging.
UseNotBlankStrfromcore.typesfor all identifier/name fields -- including optional (NotBlankStr | None) and tuple variants -- instead of manual whitespace validators.
Files:
src/synthorg/core/__init__.pysrc/synthorg/api/controllers/setup.pysrc/synthorg/core/enums.pysrc/synthorg/templates/loader.pysrc/synthorg/templates/schema.pysrc/synthorg/api/controllers/setup_models.py
src/synthorg/!(observability)/**/*.py
📄 CodeRabbit inference engine (CLAUDE.md)
Never use
import logging/logging.getLogger()/print()in application code (exception:observability/setup.pyandobservability/sinks.pymay use stdlib logging and print for bootstrap).
Files:
src/synthorg/core/__init__.pysrc/synthorg/api/controllers/setup.pysrc/synthorg/core/enums.pysrc/synthorg/templates/loader.pysrc/synthorg/templates/schema.pysrc/synthorg/api/controllers/setup_models.py
🧠 Learnings (20)
📚 Learning: 2026-03-20T08:28:32.845Z
Learnt from: CR
Repo: Aureliolo/synthorg PR: 0
File: CLAUDE.md:0-0
Timestamp: 2026-03-20T08:28:32.845Z
Learning: Applies to src/synthorg/templates/**/*.py : Templates: pre-built company templates, personality presets, and builder.
Applied to files:
docs/design/communication.mddocs/design/operations.mdsrc/synthorg/api/controllers/setup.pydocs/design/organization.mdsrc/synthorg/templates/loader.pysrc/synthorg/templates/builtins/full_company.yaml
📚 Learning: 2026-03-19T07:12:14.508Z
Learnt from: CR
Repo: Aureliolo/synthorg PR: 0
File: CLAUDE.md:0-0
Timestamp: 2026-03-19T07:12:14.508Z
Learning: Applies to src/synthorg/**/*.py : Package structure: src/synthorg/ organized as: api/ (REST+WebSocket, Litestar), auth/ (auth subpackage), backup/ (scheduled/manual backups), budget/ (cost tracking, CFO), cli/ (superseded by Go CLI), communication/ (message bus, meetings), config/ (YAML loading), core/ (domain models, resilience config), engine/ (orchestration, task state, coordination, approval gates, stagnation detection, context budget, compaction), hr/ (hiring, performance, promotion), memory/ (pluggable backend, Mem0, retrieval, consolidation), persistence/ (operational data, SQLite, settings), observability/ (logging, correlation, sinks), providers/ (LLM abstraction, LiteLLM, auth types, presets, runtime CRUD), settings/ (runtime-editable, typed definitions, encryption, config bridge), security/ (SecOps, rule engine, output scanning, progressive trust, autonomy levels), templates/ (company templates, personalities), tools/ (registry, built-in tools, git, sandbox, code_runner, MCP...
Applied to files:
src/synthorg/core/__init__.py
📚 Learning: 2026-03-16T06:24:56.341Z
Learnt from: CR
Repo: Aureliolo/synthorg PR: 0
File: CLAUDE.md:0-0
Timestamp: 2026-03-16T06:24:56.341Z
Learning: Applies to src/synthorg/core/**/*.py : Core module must contain shared domain models, base classes, resilience config (RetryConfig, RateLimiterConfig)
Applied to files:
src/synthorg/core/__init__.py
📚 Learning: 2026-03-18T21:23:23.586Z
Learnt from: CR
Repo: Aureliolo/synthorg PR: 0
File: CLAUDE.md:0-0
Timestamp: 2026-03-18T21:23:23.586Z
Learning: Applies to src/synthorg/**/*.py : Event names: always use constants from the domain-specific module under synthorg.observability.events (e.g., API_REQUEST_STARTED from events.api, TOOL_INVOKE_START from events.tool). Import directly from synthorg.observability.events.<domain>.
Applied to files:
src/synthorg/core/__init__.py
📚 Learning: 2026-03-15T18:38:44.202Z
Learnt from: CR
Repo: Aureliolo/synthorg PR: 0
File: CLAUDE.md:0-0
Timestamp: 2026-03-15T18:38:44.202Z
Learning: Applies to src/synthorg/**/*.py : Every module with business logic must import `from synthorg.observability import get_logger` and define `logger = get_logger(__name__)`
Applied to files:
src/synthorg/core/__init__.py
📚 Learning: 2026-03-22T19:37:56.694Z
Learnt from: CR
Repo: Aureliolo/synthorg PR: 0
File: CLAUDE.md:0-0
Timestamp: 2026-03-22T19:37:56.694Z
Learning: Applies to src/synthorg/**/*.py : Event names: always use constants from domain-specific modules under `synthorg.observability.events` (e.g., `API_REQUEST_STARTED` from `events.api`). Import directly: `from synthorg.observability.events.<domain> import EVENT_CONSTANT`
Applied to files:
src/synthorg/core/__init__.py
📚 Learning: 2026-03-22T19:37:56.694Z
Learnt from: CR
Repo: Aureliolo/synthorg PR: 0
File: CLAUDE.md:0-0
Timestamp: 2026-03-22T19:37:56.694Z
Learning: Applies to src/synthorg/**/*.py : Use `NotBlankStr` from `core.types` for all identifier/name fields -- including optional (`NotBlankStr | None`) and tuple variants -- instead of manual whitespace validators.
Applied to files:
src/synthorg/core/__init__.py
📚 Learning: 2026-03-15T18:38:44.202Z
Learnt from: CR
Repo: Aureliolo/synthorg PR: 0
File: CLAUDE.md:0-0
Timestamp: 2026-03-15T18:38:44.202Z
Learning: Applies to src/synthorg/**/*.py : Always use event name constants from domain-specific modules under `synthorg.observability.events` (e.g., `PROVIDER_CALL_START` from `events.provider`); import directly: `from synthorg.observability.events.<domain> import EVENT_CONSTANT`
Applied to files:
src/synthorg/core/__init__.py
📚 Learning: 2026-03-15T19:14:27.144Z
Learnt from: CR
Repo: Aureliolo/synthorg PR: 0
File: CLAUDE.md:0-0
Timestamp: 2026-03-15T19:14:27.144Z
Learning: Applies to src/synthorg/**/*.py : Use Pydantic v2 BaseModel, model_validator, computed_field, ConfigDict.
Applied to files:
tests/unit/templates/test_schema.pysrc/synthorg/templates/schema.pysrc/synthorg/api/controllers/setup_models.py
📚 Learning: 2026-03-15T18:42:17.990Z
Learnt from: CR
Repo: Aureliolo/synthorg PR: 0
File: CLAUDE.md:0-0
Timestamp: 2026-03-15T18:42:17.990Z
Learning: Applies to src/synthorg/**/*.py : Use Pydantic v2 conventions: `BaseModel`, `model_validator`, `computed_field`, `ConfigDict`
Applied to files:
tests/unit/templates/test_schema.pysrc/synthorg/templates/schema.pysrc/synthorg/api/controllers/setup_models.py
📚 Learning: 2026-03-17T22:08:13.456Z
Learnt from: CR
Repo: Aureliolo/synthorg PR: 0
File: CLAUDE.md:0-0
Timestamp: 2026-03-17T22:08:13.456Z
Learning: Applies to src/synthorg/**/*.py : Use Pydantic v2 conventions: `BaseModel`, `model_validator`, `computed_field`, `ConfigDict`. For derived values use `computed_field` instead of storing + validating redundant fields. Use `NotBlankStr` (from `core.types`) for all identifier/name fields — including optional (`NotBlankStr | None`) and tuple (`tuple[NotBlankStr, ...]`) variants — instead of manual whitespace validators.
Applied to files:
src/synthorg/templates/schema.pysrc/synthorg/api/controllers/setup_models.py
📚 Learning: 2026-03-17T11:41:02.964Z
Learnt from: CR
Repo: Aureliolo/synthorg PR: 0
File: CLAUDE.md:0-0
Timestamp: 2026-03-17T11:41:02.964Z
Learning: Applies to src/**/*.py : Models: Pydantic v2 (`BaseModel`, `model_validator`, `computed_field`, `ConfigDict`). Use `computed_field` for derived values instead of storing + validating redundant fields. Use `NotBlankStr` for all identifier/name fields — including optional (`NotBlankStr | None`) and tuple (`tuple[NotBlankStr, ...]`) variants — instead of manual whitespace validators.
Applied to files:
src/synthorg/templates/schema.py
📚 Learning: 2026-03-22T19:37:56.694Z
Learnt from: CR
Repo: Aureliolo/synthorg PR: 0
File: CLAUDE.md:0-0
Timestamp: 2026-03-22T19:37:56.694Z
Learning: Applies to **/*.py : Models: Pydantic v2 (`BaseModel`, `model_validator`, `computed_field`, `ConfigDict`). Use `computed_field` for derived values. Use `NotBlankStr` for all identifier/name fields instead of manual whitespace validators.
Applied to files:
src/synthorg/templates/schema.py
📚 Learning: 2026-03-15T19:14:27.144Z
Learnt from: CR
Repo: Aureliolo/synthorg PR: 0
File: CLAUDE.md:0-0
Timestamp: 2026-03-15T19:14:27.144Z
Learning: Applies to src/synthorg/**/*.py : Use Pydantic v2 with adopted conventions: use computed_field for derived values instead of storing + validating redundant fields; use NotBlankStr from core.types for all identifier/name fields (including optional and tuple variants) instead of manual whitespace validators.
Applied to files:
src/synthorg/templates/schema.py
📚 Learning: 2026-03-15T19:14:27.144Z
Learnt from: CR
Repo: Aureliolo/synthorg PR: 0
File: CLAUDE.md:0-0
Timestamp: 2026-03-15T19:14:27.144Z
Learning: Applies to **/*.py : Models: Pydantic v2 (BaseModel, model_validator, computed_field, ConfigDict). Use computed_field for derived values instead of storing + validating redundant fields. Use NotBlankStr (from core.types) for all identifier/name fields — including optional (NotBlankStr | None) and tuple (tuple[NotBlankStr, ...]) variants — instead of manual whitespace validators.
Applied to files:
src/synthorg/templates/schema.py
📚 Learning: 2026-03-15T18:38:44.202Z
Learnt from: CR
Repo: Aureliolo/synthorg PR: 0
File: CLAUDE.md:0-0
Timestamp: 2026-03-15T18:38:44.202Z
Learning: Applies to src/synthorg/**/*.py : Use frozen Pydantic models for config/identity; separate mutable-via-copy models (using `model_copy(update=...)`) for runtime state
Applied to files:
src/synthorg/api/controllers/setup_models.py
📚 Learning: 2026-03-15T19:14:27.144Z
Learnt from: CR
Repo: Aureliolo/synthorg PR: 0
File: CLAUDE.md:0-0
Timestamp: 2026-03-15T19:14:27.144Z
Learning: Applies to src/synthorg/**/*.py : Use frozen Pydantic models for config/identity; use separate mutable-via-copy models (using model_copy(update=...)) for runtime state that evolves. Never mix static config fields with mutable runtime fields in one model.
Applied to files:
src/synthorg/api/controllers/setup_models.py
📚 Learning: 2026-03-15T19:14:27.144Z
Learnt from: CR
Repo: Aureliolo/synthorg PR: 0
File: CLAUDE.md:0-0
Timestamp: 2026-03-15T19:14:27.144Z
Learning: Applies to src/synthorg/**/*.py : For dict/list fields in frozen Pydantic models, rely on frozen=True for field reassignment prevention and copy.deepcopy() at system boundaries (tool execution, LLM provider serialization, inter-agent delegation, serializing for persistence).
Applied to files:
src/synthorg/api/controllers/setup_models.py
📚 Learning: 2026-03-15T18:38:44.202Z
Learnt from: CR
Repo: Aureliolo/synthorg PR: 0
File: CLAUDE.md:0-0
Timestamp: 2026-03-15T18:38:44.202Z
Learning: Applies to **/*.py : Config vs runtime state: frozen Pydantic models for config/identity; separate mutable-via-copy models (using model_copy(update=...)) for runtime state that evolves. Never mix static config fields with mutable runtime fields in one model.
Applied to files:
src/synthorg/api/controllers/setup_models.py
📚 Learning: 2026-03-22T19:37:56.694Z
Learnt from: CR
Repo: Aureliolo/synthorg PR: 0
File: CLAUDE.md:0-0
Timestamp: 2026-03-22T19:37:56.694Z
Learning: Applies to src/synthorg/**/*.py : Vendor-agnostic everywhere: NEVER use real vendor names (Anthropic, OpenAI, Claude, GPT, etc.) in project-owned code, docstrings, comments, tests, or config examples. Use generic names: `example-provider`, `example-large-001`, `example-medium-001`, `example-small-001`, `large`/`medium`/`small` as aliases.
Applied to files:
src/synthorg/templates/builtins/full_company.yaml
🧬 Code graph analysis (6)
src/synthorg/core/__init__.py (2)
web/src/api/types.ts (1)
SkillPattern(847-852)src/synthorg/core/enums.py (1)
SkillPattern(175-198)
src/synthorg/core/enums.py (1)
web/src/api/types.ts (1)
SkillPattern(847-852)
tests/unit/templates/test_schema.py (2)
src/synthorg/core/enums.py (2)
CompanyType(148-158)SkillPattern(175-198)src/synthorg/templates/schema.py (1)
TemplateMetadata(199-254)
web/src/api/types.ts (2)
src/synthorg/core/enums.py (1)
SkillPattern(175-198)src/synthorg/api/controllers/setup_models.py (1)
TemplateInfoResponse(36-61)
src/synthorg/templates/schema.py (2)
src/synthorg/core/enums.py (1)
SkillPattern(175-198)web/src/api/types.ts (1)
SkillPattern(847-852)
tests/unit/templates/test_loader.py (4)
web/src/api/types.ts (1)
SkillPattern(847-852)src/synthorg/core/enums.py (1)
SkillPattern(175-198)src/synthorg/templates/loader.py (2)
load_template(169-225)load_template_file(228-249)tests/unit/templates/conftest.py (2)
tmp_template_file(217-225)TemplateFileFactory(12-15)
🔇 Additional comments (36)
src/synthorg/core/enums.py (1)
175-198: LGTM!The
SkillPatternenum is well-documented with a clear taxonomy description and per-member docstrings. The string values align with the TypeScript union type inweb/src/api/types.ts(lines 846-851), ensuring API consistency.src/synthorg/core/__init__.py (1)
51-51: LGTM!The
SkillPatternimport is correctly added and re-exported via__all__, maintaining alphabetical ordering.src/synthorg/templates/schema.py (1)
226-254: LGTM!The
tagsandskill_patternsfields are correctly implemented:
- Immutable
tupletypes appropriate for a frozen modelNotBlankStrused for tags per coding guidelines- Duplicate
skill_patternsvalidator logs before raising and produces deterministic sorted outputdocs/design/operations.md (1)
846-847: LGTM!Documentation correctly updated to reflect the renamed template display names (Solo Founder → Solo Builder, Full Company → Enterprise Org), aligning with the PR objectives.
tests/unit/api/controllers/test_setup.py (1)
49-50: LGTM!Test correctly extended to verify that the
/api/v1/setup/templatesresponse includes the newtagsandskill_patternsfields, aligning with theTemplateInfoResponsemodel updates.docs/design/communication.md (1)
89-90: LGTM!Documentation correctly updated to reflect the renamed template display names, maintaining consistency with
docs/design/operations.mdand the PR objectives.src/synthorg/api/controllers/setup.py (1)
205-206: LGTM!The controller correctly passes the
tagsandskill_patternsfields from theTemplateInfoobject to theTemplateInfoResponse, completing the API surface exposure of the new metadata.src/synthorg/templates/builtins/startup.yaml (1)
3-21: LGTM!The template metadata is well-updated:
- Description rewritten as a concise 2-3 sentence summary per PR objectives
- Tags expanded with capability-specific values (
agile,iterative,lean)skill_patternsvalues (tool_wrapper,generator,pipeline) are validSkillPatternenum memberstests/unit/templates/test_schema.py (4)
8-8: LGTM!Import correctly includes
SkillPatternfromsynthorg.core.enumsto support the new skill pattern tests.
201-201: LGTM!Properly asserts the default empty tuple for
skill_patternsin the minimal case.
212-222: LGTM!Good coverage of the full case with multiple skill patterns. The assertion correctly verifies that the stored tuple matches the input.
241-250: LGTM!Properly tests the uniqueness validator by passing duplicate
PIPELINEentries and asserting the expected validation error message.web/src/api/types.ts (2)
847-852: LGTM!The
SkillPatternunion type correctly mirrors the backendSkillPatternenum values, providing frontend type safety.
859-860: LGTM!The
tagsandskill_patternsfields correctly usereadonlyarrays for immutability, andskill_patternsuses theSkillPatterntype for compile-time validation.src/synthorg/templates/builtins/research_lab.yaml (2)
3-7: LGTM!Clear, informative description that explains the template's distinctive approach: structured inquiry before data work, with peer-reviewed output.
14-20: LGTM!Tags and skill patterns are well-chosen. The patterns (inversion, generator, reviewer) correctly reflect the research workflow: defining questions first (inversion), producing structured artifacts (generator), and peer review before publication (reviewer).
src/synthorg/templates/loader.py (5)
71-80: LGTM!
TemplateInfodataclass correctly extended withtagsandskill_patternsfields, both defaulting to empty tuples. Docstring properly documents the new attributes.
122-123: LGTM!Correctly populates
tagsandskill_patternsfrom template metadata. Theskill_patternsare properly converted from enum values to strings viasp.value.
149-150: LGTM!Consistent with the builtin template handling — user templates also populate
tagsandskill_patternsfrom metadata.
441-441: LGTM!Correctly extracts
skill_patternsfrom YAML data during normalization, defaulting to an empty tuple when absent.
486-486: LGTM!Correctly uses PEP 758 except syntax (
except TypeError, ValueError:without parentheses) as per coding guidelines.src/synthorg/api/controllers/setup_models.py (2)
44-48: LGTM!Docstring properly documents the new attributes, and adding
extra="forbid"toConfigDicttightens response validation to reject unexpected fields.
54-61: LGTM!Fields correctly typed as
tuple[str, ...]for JSON serialization. Using string tuples rather than the enum type is appropriate for the API response layer since the loader already convertsSkillPatternvalues to strings.docs/design/organization.md (2)
14-21: LGTM!Template table correctly updated with renamed display names. The use cases and operational configurations remain consistent with the template archetypes.
26-54: LGTM!Excellent documentation of the skill pattern taxonomy. The section clearly explains each pattern's purpose and documents which patterns each template exhibits. The composability explanation helps users understand how patterns can be combined.
src/synthorg/templates/builtins/solo_founder.yaml (2)
2-7: LGTM!Template renamed to "Solo Builder" with a clear description explaining the lean, two-agent, event-driven setup with full autonomy.
14-18: LGTM!Tags appropriately updated, and the single
tool_wrapperskill pattern is correct for this minimal template where agents self-direct using specialized context.tests/unit/templates/test_loader.py (5)
9-9: LGTM!Import of
SkillPatternenum correctly added for the new skill pattern validation tests.
152-157: LGTM!Assertions correctly updated to expect "Solo Builder" instead of "Solo Founder" to match the renamed template.
182-183: LGTM!Comment correctly updated to clarify that the user template has "Test Template" name, not "Solo Builder".
237-255: LGTM!Good test coverage for invalid skill pattern rejection. The test correctly uses an invalid pattern value and asserts
TemplateValidationErroris raised during loading.
417-483: LGTM!Comprehensive test suite for builtin skill patterns. The tests are well-structured:
- Coverage check ensures all builtins are tested
- Validation that all builtins declare at least one pattern
- Validation that all pattern values are valid enum members
- Order-insensitive pattern matching using set comparison (line 482-483)
src/synthorg/templates/builtins/dev_shop.yaml (1)
13-20: Tag and skill-pattern classification looks consistent.The added tags and
skill_patternsare coherent with the taxonomy and improve discoverability.src/synthorg/templates/builtins/agency.yaml (1)
3-21: Metadata update is clear and taxonomy-aligned.Description, expanded tags, and
skill_patternsare consistent and improve template filtering/intent clarity.src/synthorg/templates/builtins/full_company.yaml (1)
2-23: Enterprise metadata changes are internally consistent.The new name, expanded tags, and full five-pattern classification are coherent and match the taxonomy intent.
src/synthorg/templates/builtins/product_team.yaml (1)
2-21: Product template metadata update looks solid.The rename, rewritten description, capability tags, and pattern mapping are consistent and well-scoped.
| description: >- | ||
| A lean engineering team built for shipping. No C-suite overhead | ||
| -- a Software Architect leads directly. Three backend developers, | ||
| a frontend specialist, QA pipeline, and a DevOps engineer. | ||
| Optimized for throughput with quality gates. |
There was a problem hiding this comment.
Condense this to 2–3 sentences to match the metadata standard.
This description currently reads as 4 sentences, which misses the PR objective for concise 2–3 sentence summaries.
🤖 Prompt for AI Agents
Verify each finding against the current code and only fix it if needed.
In `@src/synthorg/templates/builtins/dev_shop.yaml` around lines 3 - 7, The YAML
"description" field is too verbose; rewrite the description in
src/synthorg/templates/builtins/dev_shop.yaml to 2–3 sentences only, preserving
key facts (lean engineering team led by a Software Architect, core roles: three
backend developers, frontend specialist, QA pipeline, DevOps engineer, and focus
on throughput with quality gates). Replace the existing multi-sentence paragraph
under the description key with a concise 2–3 sentence summary that bundles roles
and purpose into one or two combined sentences and ends with the
optimization/quality intent.
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
There was a problem hiding this comment.
Code Review
This pull request introduces a SkillPattern taxonomy to provide richer metadata for company templates. The changes are comprehensive, updating documentation, backend models and logic, API responses, and frontend types. The implementation is of high quality, with thorough test coverage for the new functionality. My review includes a couple of minor suggestions to improve the clarity of the documentation and the maintainability of the test data.
docs/design/organization.md
Outdated
| | **Engineering Squad** | Pipeline, Reviewer, Tool Wrapper | | ||
| | **Product Studio** | Inversion, Pipeline, Reviewer | | ||
| | **Agency** | Pipeline, Generator, Reviewer | | ||
| | **Enterprise Org** | All five | |
There was a problem hiding this comment.
For consistency with the other rows in this table, it would be clearer to explicitly list all five skill patterns instead of using the text "All five". This makes the table easier to scan and understand without cross-referencing the taxonomy definition table above.
| | **Enterprise Org** | All five | | |
| | **Enterprise Org** | Tool Wrapper, Generator, Reviewer, Inversion, Pipeline | |
| _EXPECTED_PATTERNS: ClassVar[list[tuple[str, tuple[str, ...]]]] = [ | ||
| ("solo_founder", ("tool_wrapper",)), | ||
| ("startup", ("tool_wrapper", "generator", "pipeline")), | ||
| ( | ||
| "dev_shop", | ||
| ("pipeline", "reviewer", "tool_wrapper"), | ||
| ), | ||
| ( | ||
| "product_team", | ||
| ("inversion", "pipeline", "reviewer"), | ||
| ), | ||
| ("agency", ("pipeline", "generator", "reviewer")), | ||
| ( | ||
| "full_company", | ||
| ( | ||
| "tool_wrapper", | ||
| "generator", | ||
| "reviewer", | ||
| "inversion", | ||
| "pipeline", | ||
| ), | ||
| ), | ||
| ( | ||
| "research_lab", | ||
| ("inversion", "generator", "reviewer"), | ||
| ), | ||
| ] |
There was a problem hiding this comment.
For better readability and consistency in the test data, consider sorting the skill patterns alphabetically within each tuple in _EXPECTED_PATTERNS. While the test correctly uses sets for comparison, making the order irrelevant for correctness, sorted test data is easier to maintain and visually inspect for differences.
_EXPECTED_PATTERNS: ClassVar[list[tuple[str, tuple[str, ...]]]] = [
("solo_founder", ("tool_wrapper",)),
("startup", ("generator", "pipeline", "tool_wrapper")),
(
"dev_shop",
("pipeline", "reviewer", "tool_wrapper"),
),
(
"product_team",
("inversion", "pipeline", "reviewer"),
),
("agency", ("generator", "pipeline", "reviewer")),
(
"full_company",
(
"generator",
"inversion",
"pipeline",
"reviewer",
"tool_wrapper",
),
),
(
"research_lab",
("generator", "inversion", "reviewer"),
),
]
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #752 +/- ##
==========================================
+ Coverage 92.29% 92.31% +0.01%
==========================================
Files 573 573
Lines 29704 29727 +23
Branches 2879 2881 +2
==========================================
+ Hits 27414 27441 +27
+ Misses 1810 1806 -4
Partials 480 480 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
…, and display names Add SkillPattern enum (tool_wrapper, generator, reviewer, inversion, pipeline) based on Google Cloud's five-pattern taxonomy for agent collaboration. Each builtin template is classified by which patterns its agents use. Rewrite template descriptions from vague one-liners to informative 2-3 sentence summaries explaining what makes each template distinct. Expand tags with capability-specific values (ci-cd, code-review, user-research, etc.) beyond generic categorization. Update display names for clarity: Solo Founder -> Solo Builder, Dev Shop -> Engineering Squad, Product Team -> Product Studio, Full Company -> Enterprise Org. Surface tags and skill_patterns through TemplateInfo, the REST API (TemplateInfoResponse), and the TypeScript interface for the web dashboard. Closes #698 Co-Authored-By: Claude Opus 4.6 (1M context) <[email protected]>
Fix stale display names in communication.md and operations.md. Add SkillPattern uniqueness validator to TemplateMetadata. Add TypeScript SkillPattern union type for type-safe frontend usage. Use set comparison in test_expected_patterns to avoid order sensitivity. Add test for invalid skill_patterns rejection. Add extra="forbid" to TemplateInfoResponse. Fix stale test comment. Pre-reviewed by 7 agents, 8 findings addressed. Co-Authored-By: Claude Opus 4.6 (1M context) <[email protected]>
…mini - Strengthen TemplateInfoResponse types: tags uses NotBlankStr, skill_patterns uses SkillPattern enum (preserving type safety through the full DTO chain) - Add subordinate_id/supervisor_id to DepartmentReportingLine TypeScript type - Add head_id to DepartmentEntry TypeScript type - Fix ReportingLine and Department docstrings: "agent name" -> "role name" - Soften subordinate_id/supervisor_id docstring: remove template-specific merge_id reference, use generic "stable unique string" phrasing - Add _identity_key docstring examples for tuple namespace clarity - Add head_merge_id_requires_head_role validator on TemplateDepartmentConfig - Fix head_merge_id docstring: "Required" -> "Should be provided" - Align _validate_unique_skill_patterns with Counter-only class convention - Add SkillPattern to TestEnumMemberCounts (5 members) - Add head_merge_id tests: default None, valid with head_role, blank/whitespace rejected, without head_role rejected - Remove dead test_all_pattern_values_are_valid (enum membership guaranteed) - Sort _EXPECTED_PATTERNS alphabetically for readability - Update dev_shop.yaml company_name default from "Dev Shop" to "Engineering Squad" - List all five pattern names in organization.md table instead of "All five" - Improve tags/skill_patterns descriptions in DTOs Co-Authored-By: Claude Opus 4.6 (1M context) <[email protected]>
Aureliolo
force-pushed
the
feat/implement-698
branch
from
9e7c753 to
5bdd2bf
Compare
Aureliolo
temporarily deployed
to
cloudflare-preview
GitHub Actions
Inactive
There was a problem hiding this comment.
Actionable comments posted: 2
♻️ Duplicate comments (1)
src/synthorg/templates/builtins/dev_shop.yaml (1)
3-7:⚠️ Potential issue | 🟡 MinorCondense this description to 2–3 sentences.
This remains 4 sentences, so it still misses the PR objective for concise template summaries.
Proposed edit
description: >- - A lean engineering team built for shipping. No C-suite overhead - -- a Software Architect leads directly. Three backend developers, - a frontend specialist, QA pipeline, and a DevOps engineer. - Optimized for throughput with quality gates. + A lean engineering squad optimized for fast shipping, led directly + by a Software Architect without C-suite overhead. It combines three + backend developers, a frontend specialist, QA pipeline, and DevOps + support to keep delivery moving. Built for throughput with explicit + quality gates.🤖 Prompt for AI Agents
Verify each finding against the current code and only fix it if needed. In `@src/synthorg/templates/builtins/dev_shop.yaml` around lines 3 - 7, The description field in dev_shop.yaml is still four sentences; update the description value so it is condensed into 2–3 sentences while preserving the key points: a lean engineering team led by a Software Architect, the core roles (backend, frontend, QA, DevOps), and the focus on throughput with quality gates; modify the 'description' string in src/synthorg/templates/builtins/dev_shop.yaml (the description: >- block) to combine or trim phrases into two or three concise sentences that convey leadership, team composition, and optimization for throughput with quality controls.
🤖 Prompt for all review comments with AI agents
Verify each finding against the current code and only fix it if needed.
Inline comments:
In `@tests/unit/api/controllers/test_setup.py`:
- Around line 49-50: The test currently only asserts presence of "tags" and
"skill_patterns" in the template; strengthen these to assert concrete shapes and
simple value constraints: verify template["tags"] is a list of non-empty strings
(e.g., isinstance(list) and all(isinstance(t, str) and t.strip() for t in
template["tags"])), and verify template["skill_patterns"] is a list of dict-like
objects where each entry contains expected keys (e.g., "name" and "pattern")
with non-empty string values (e.g., isinstance and non-empty checks). Update the
assertions that reference the template variable in
tests/unit/api/controllers/test_setup.py to use these type/shape/value checks so
serialization regressions are caught.
In `@tests/unit/core/test_enums.py`:
- Around line 104-105: The test test_skill_pattern_has_5_members only asserts
cardinality; change it to assert explicit enum values to catch accidental
renames — update the test (keeping or renaming test_skill_pattern_has_5_members)
to assert that the set/list of SkillPattern members equals the expected values
(e.g., compare [m.value for m in SkillPattern] or [m.name for m in SkillPattern]
to the explicit expected list/order), so the test fails if any SkillPattern
member name or value changes.
---
Duplicate comments:
In `@src/synthorg/templates/builtins/dev_shop.yaml`:
- Around line 3-7: The description field in dev_shop.yaml is still four
sentences; update the description value so it is condensed into 2–3 sentences
while preserving the key points: a lean engineering team led by a Software
Architect, the core roles (backend, frontend, QA, DevOps), and the focus on
throughput with quality gates; modify the 'description' string in
src/synthorg/templates/builtins/dev_shop.yaml (the description: >- block) to
combine or trim phrases into two or three concise sentences that convey
leadership, team composition, and optimization for throughput with quality
controls.
🪄 Autofix (Beta)
Fix all unresolved CodeRabbit comments on this PR:
- Push a commit to this branch (recommended)
- Create a new PR with the fixes
ℹ️ Review info
⚙️ Run configuration
Configuration used: Repository UI
Review profile: ASSERTIVE
Plan: Pro
Run ID: de43877d-dd4e-496a-89d8-55805f7659ff
📒 Files selected for processing (22)
docs/design/communication.mddocs/design/operations.mddocs/design/organization.mdsrc/synthorg/api/controllers/setup.pysrc/synthorg/api/controllers/setup_models.pysrc/synthorg/core/__init__.pysrc/synthorg/core/company.pysrc/synthorg/core/enums.pysrc/synthorg/templates/builtins/agency.yamlsrc/synthorg/templates/builtins/dev_shop.yamlsrc/synthorg/templates/builtins/full_company.yamlsrc/synthorg/templates/builtins/product_team.yamlsrc/synthorg/templates/builtins/research_lab.yamlsrc/synthorg/templates/builtins/solo_founder.yamlsrc/synthorg/templates/builtins/startup.yamlsrc/synthorg/templates/loader.pysrc/synthorg/templates/schema.pytests/unit/api/controllers/test_setup.pytests/unit/core/test_enums.pytests/unit/templates/test_loader.pytests/unit/templates/test_schema.pyweb/src/api/types.ts
📜 Review details
🧰 Additional context used
📓 Path-based instructions (4)
**/*.py
📄 CodeRabbit inference engine (CLAUDE.md)
**/*.py: Nofrom __future__ import annotations-- Python 3.14 has PEP 649 native lazy annotations.
Use PEP 758 except syntax:except A, B:(no parentheses) -- ruff enforces this on Python 3.14.
Type hints: all public functions, mypy strict mode.
Docstrings: Google style, required on public classes/functions (enforced by ruff D rules).
Immutability: create new objects, never mutate existing ones. For non-Pydantic internal collections, usecopy.deepcopy()at construction +MappingProxyTypewrapping for read-only enforcement. Fordict/listfields in frozen Pydantic models, rely onfrozen=Trueandcopy.deepcopy()at system boundaries.
Config vs runtime state: frozen Pydantic models for config/identity; separate mutable-via-copy models for runtime state that evolves. Never mix static config fields with mutable runtime fields.
Models: Pydantic v2 (BaseModel,model_validator,computed_field,ConfigDict). Use@computed_fieldfor derived values. UseNotBlankStrfor all identifier/name fields instead of manual whitespace validators.
Async concurrency: preferasyncio.TaskGroupfor fan-out/fan-in parallel operations in new code. Prefer structured concurrency over barecreate_task.
Line length: 88 characters (ruff).
Functions: < 50 lines, files < 800 lines.
Errors: handle explicitly, never silently swallow.
Validate: at system boundaries (user input, external APIs, config files).
Variable name: alwayslogger(not_logger, notlog).
Files:
tests/unit/api/controllers/test_setup.pytests/unit/core/test_enums.pysrc/synthorg/templates/loader.pysrc/synthorg/api/controllers/setup_models.pytests/unit/templates/test_loader.pysrc/synthorg/core/company.pytests/unit/templates/test_schema.pysrc/synthorg/templates/schema.pysrc/synthorg/api/controllers/setup.pysrc/synthorg/core/__init__.pysrc/synthorg/core/enums.py
tests/**/*.py
📄 CodeRabbit inference engine (CLAUDE.md)
tests/**/*.py: Markers:@pytest.mark.unit,@pytest.mark.integration,@pytest.mark.e2e,@pytest.mark.slow
Parametrize: Prefer@pytest.mark.parametrizefor testing similar cases.
Tests must usetest-provider,test-small-001, etc. for vendor-agnostic test code.
Property-based testing: Python uses Hypothesis (@given+@settings). Hypothesis profiles:ci(50 examples, default) anddev(1000 examples), controlled viaHYPOTHESIS_PROFILEenv var.
Flaky tests: NEVER skip, dismiss, or ignore -- always fix them fully and fundamentally. For timing-sensitive tests, mocktime.monotonic()andasyncio.sleep()to make them deterministic. For tasks that must block indefinitely until cancelled, useasyncio.Event().wait()instead ofasyncio.sleep(large_number).
Files:
tests/unit/api/controllers/test_setup.pytests/unit/core/test_enums.pytests/unit/templates/test_loader.pytests/unit/templates/test_schema.py
src/synthorg/**/*.py
📄 CodeRabbit inference engine (CLAUDE.md)
src/synthorg/**/*.py: Every module with business logic MUST have:from synthorg.observability import get_loggerthenlogger = get_logger(__name__)
Event names: always use constants from domain-specific modules undersynthorg.observability.events(e.g.,API_REQUEST_STARTEDfromevents.api). Import directly:from synthorg.observability.events.<domain> import EVENT_CONSTANT
Structured kwargs: alwayslogger.info(EVENT, key=value)-- neverlogger.info("msg %s", val)
All error paths must log at WARNING or ERROR with context before raising.
All state transitions must log at INFO.
DEBUG for object creation, internal flow, entry/exit of key functions.
Vendor-agnostic everywhere: NEVER use real vendor names (Anthropic, OpenAI, Claude, GPT, etc.) in project-owned code, docstrings, comments, tests, or config examples. Use generic names:example-provider,example-large-001,example-medium-001,example-small-001,large/medium/smallas aliases.
Pure data models, enums, and re-exports do NOT need logging.
UseNotBlankStrfromcore.typesfor all identifier/name fields -- including optional (NotBlankStr | None) and tuple variants -- instead of manual whitespace validators.
Files:
src/synthorg/templates/loader.pysrc/synthorg/api/controllers/setup_models.pysrc/synthorg/core/company.pysrc/synthorg/templates/schema.pysrc/synthorg/api/controllers/setup.pysrc/synthorg/core/__init__.pysrc/synthorg/core/enums.py
src/synthorg/!(observability)/**/*.py
📄 CodeRabbit inference engine (CLAUDE.md)
Never use
import logging/logging.getLogger()/print()in application code (exception:observability/setup.pyandobservability/sinks.pymay use stdlib logging and print for bootstrap).
Files:
src/synthorg/templates/loader.pysrc/synthorg/api/controllers/setup_models.pysrc/synthorg/core/company.pysrc/synthorg/templates/schema.pysrc/synthorg/api/controllers/setup.pysrc/synthorg/core/__init__.pysrc/synthorg/core/enums.py
🧠 Learnings (20)
📚 Learning: 2026-03-19T07:12:14.508Z
Learnt from: CR
Repo: Aureliolo/synthorg PR: 0
File: CLAUDE.md:0-0
Timestamp: 2026-03-19T07:12:14.508Z
Learning: Applies to docs/design/*.md : Design spec pages: 7 pages in `docs/design/` — index, agents, organization, communication, engine, memory, operations
Applied to files:
docs/design/communication.mddocs/design/organization.md
📚 Learning: 2026-03-16T06:24:56.341Z
Learnt from: CR
Repo: Aureliolo/synthorg PR: 0
File: CLAUDE.md:0-0
Timestamp: 2026-03-16T06:24:56.341Z
Learning: Applies to docs/design/**/*.md : Design specification pages in `docs/design/` must be consulted before implementing features (7 pages: index, agents, organization, communication, engine, memory, operations)
Applied to files:
docs/design/communication.md
📚 Learning: 2026-03-19T07:13:44.964Z
Learnt from: CR
Repo: Aureliolo/synthorg PR: 0
File: CLAUDE.md:0-0
Timestamp: 2026-03-19T07:13:44.964Z
Learning: Always read the relevant `docs/design/` page before implementing any feature or planning any issue — DESIGN_SPEC.md is a pointer file linking to 7 design pages (Agents, Organization, Communication, Engine, Memory, Operations)
Applied to files:
docs/design/communication.md
📚 Learning: 2026-03-20T08:28:32.845Z
Learnt from: CR
Repo: Aureliolo/synthorg PR: 0
File: CLAUDE.md:0-0
Timestamp: 2026-03-20T08:28:32.845Z
Learning: Applies to src/synthorg/templates/**/*.py : Templates: pre-built company templates, personality presets, and builder.
Applied to files:
docs/design/communication.mddocs/design/operations.mdsrc/synthorg/templates/loader.pydocs/design/organization.mdsrc/synthorg/templates/builtins/solo_founder.yamlsrc/synthorg/templates/builtins/full_company.yamlsrc/synthorg/api/controllers/setup.py
📚 Learning: 2026-03-15T19:14:27.144Z
Learnt from: CR
Repo: Aureliolo/synthorg PR: 0
File: CLAUDE.md:0-0
Timestamp: 2026-03-15T19:14:27.144Z
Learning: Applies to src/synthorg/**/*.py : Use Pydantic v2 BaseModel, model_validator, computed_field, ConfigDict.
Applied to files:
src/synthorg/templates/loader.pysrc/synthorg/api/controllers/setup_models.pytests/unit/templates/test_schema.pysrc/synthorg/templates/schema.py
📚 Learning: 2026-03-17T22:08:13.456Z
Learnt from: CR
Repo: Aureliolo/synthorg PR: 0
File: CLAUDE.md:0-0
Timestamp: 2026-03-17T22:08:13.456Z
Learning: Applies to src/synthorg/**/*.py : Handle errors explicitly, never silently swallow. Validate at system boundaries (user input, external APIs, config files).
Applied to files:
src/synthorg/templates/loader.py
📚 Learning: 2026-03-17T06:43:14.114Z
Learnt from: CR
Repo: Aureliolo/synthorg PR: 0
File: CLAUDE.md:0-0
Timestamp: 2026-03-17T06:43:14.114Z
Learning: Applies to src/synthorg/**/*.py : All error paths must log at WARNING or ERROR with context before raising. All state transitions must log at INFO. DEBUG for object creation, internal flow, entry/exit of key functions. Pure data models, enums, and re-exports do NOT need logging.
Applied to files:
src/synthorg/templates/loader.py
📚 Learning: 2026-03-17T22:08:13.456Z
Learnt from: CR
Repo: Aureliolo/synthorg PR: 0
File: CLAUDE.md:0-0
Timestamp: 2026-03-17T22:08:13.456Z
Learning: Applies to src/synthorg/**/*.py : All error paths must log at WARNING or ERROR with context before raising. All state transitions must log at INFO. DEBUG for object creation, internal flow, entry/exit of key functions.
Applied to files:
src/synthorg/templates/loader.py
📚 Learning: 2026-03-15T18:38:44.202Z
Learnt from: CR
Repo: Aureliolo/synthorg PR: 0
File: CLAUDE.md:0-0
Timestamp: 2026-03-15T18:38:44.202Z
Learning: Applies to src/synthorg/**/*.py : Use frozen Pydantic models for config/identity; separate mutable-via-copy models (using `model_copy(update=...)`) for runtime state
Applied to files:
src/synthorg/api/controllers/setup_models.py
📚 Learning: 2026-03-15T19:14:27.144Z
Learnt from: CR
Repo: Aureliolo/synthorg PR: 0
File: CLAUDE.md:0-0
Timestamp: 2026-03-15T19:14:27.144Z
Learning: Applies to src/synthorg/**/*.py : Use frozen Pydantic models for config/identity; use separate mutable-via-copy models (using model_copy(update=...)) for runtime state that evolves. Never mix static config fields with mutable runtime fields in one model.
Applied to files:
src/synthorg/api/controllers/setup_models.py
📚 Learning: 2026-03-17T22:08:13.456Z
Learnt from: CR
Repo: Aureliolo/synthorg PR: 0
File: CLAUDE.md:0-0
Timestamp: 2026-03-17T22:08:13.456Z
Learning: Applies to src/synthorg/**/*.py : Use Pydantic v2 conventions: `BaseModel`, `model_validator`, `computed_field`, `ConfigDict`. For derived values use `computed_field` instead of storing + validating redundant fields. Use `NotBlankStr` (from `core.types`) for all identifier/name fields — including optional (`NotBlankStr | None`) and tuple (`tuple[NotBlankStr, ...]`) variants — instead of manual whitespace validators.
Applied to files:
src/synthorg/api/controllers/setup_models.pysrc/synthorg/templates/schema.py
📚 Learning: 2026-03-15T18:42:17.990Z
Learnt from: CR
Repo: Aureliolo/synthorg PR: 0
File: CLAUDE.md:0-0
Timestamp: 2026-03-15T18:42:17.990Z
Learning: Applies to src/synthorg/**/*.py : Use Pydantic v2 conventions: `BaseModel`, `model_validator`, `computed_field`, `ConfigDict`
Applied to files:
src/synthorg/api/controllers/setup_models.pytests/unit/templates/test_schema.pysrc/synthorg/templates/schema.py
📚 Learning: 2026-03-15T19:14:27.144Z
Learnt from: CR
Repo: Aureliolo/synthorg PR: 0
File: CLAUDE.md:0-0
Timestamp: 2026-03-15T19:14:27.144Z
Learning: Applies to src/synthorg/**/*.py : For dict/list fields in frozen Pydantic models, rely on frozen=True for field reassignment prevention and copy.deepcopy() at system boundaries (tool execution, LLM provider serialization, inter-agent delegation, serializing for persistence).
Applied to files:
src/synthorg/api/controllers/setup_models.py
📚 Learning: 2026-03-17T11:41:02.964Z
Learnt from: CR
Repo: Aureliolo/synthorg PR: 0
File: CLAUDE.md:0-0
Timestamp: 2026-03-17T11:41:02.964Z
Learning: Applies to src/**/*.py : Models: Pydantic v2 (`BaseModel`, `model_validator`, `computed_field`, `ConfigDict`). Use `computed_field` for derived values instead of storing + validating redundant fields. Use `NotBlankStr` for all identifier/name fields — including optional (`NotBlankStr | None`) and tuple (`tuple[NotBlankStr, ...]`) variants — instead of manual whitespace validators.
Applied to files:
src/synthorg/api/controllers/setup_models.pysrc/synthorg/templates/schema.py
📚 Learning: 2026-03-22T19:37:56.694Z
Learnt from: CR
Repo: Aureliolo/synthorg PR: 0
File: CLAUDE.md:0-0
Timestamp: 2026-03-22T19:37:56.694Z
Learning: Applies to **/*.py : Models: Pydantic v2 (`BaseModel`, `model_validator`, `computed_field`, `ConfigDict`). Use `computed_field` for derived values. Use `NotBlankStr` for all identifier/name fields instead of manual whitespace validators.
Applied to files:
src/synthorg/api/controllers/setup_models.pysrc/synthorg/templates/schema.py
📚 Learning: 2026-03-15T19:14:27.144Z
Learnt from: CR
Repo: Aureliolo/synthorg PR: 0
File: CLAUDE.md:0-0
Timestamp: 2026-03-15T19:14:27.144Z
Learning: Applies to **/*.py : Models: Pydantic v2 (BaseModel, model_validator, computed_field, ConfigDict). Use computed_field for derived values instead of storing + validating redundant fields. Use NotBlankStr (from core.types) for all identifier/name fields — including optional (NotBlankStr | None) and tuple (tuple[NotBlankStr, ...]) variants — instead of manual whitespace validators.
Applied to files:
src/synthorg/api/controllers/setup_models.pysrc/synthorg/templates/schema.py
📚 Learning: 2026-03-15T19:14:27.144Z
Learnt from: CR
Repo: Aureliolo/synthorg PR: 0
File: CLAUDE.md:0-0
Timestamp: 2026-03-15T19:14:27.144Z
Learning: Applies to src/synthorg/**/*.py : Use Pydantic v2 with adopted conventions: use computed_field for derived values instead of storing + validating redundant fields; use NotBlankStr from core.types for all identifier/name fields (including optional and tuple variants) instead of manual whitespace validators.
Applied to files:
src/synthorg/api/controllers/setup_models.pysrc/synthorg/templates/schema.py
📚 Learning: 2026-03-22T19:37:56.694Z
Learnt from: CR
Repo: Aureliolo/synthorg PR: 0
File: CLAUDE.md:0-0
Timestamp: 2026-03-22T19:37:56.694Z
Learning: Applies to src/synthorg/**/*.py : Vendor-agnostic everywhere: NEVER use real vendor names (Anthropic, OpenAI, Claude, GPT, etc.) in project-owned code, docstrings, comments, tests, or config examples. Use generic names: `example-provider`, `example-large-001`, `example-medium-001`, `example-small-001`, `large`/`medium`/`small` as aliases.
Applied to files:
src/synthorg/templates/builtins/full_company.yaml
📚 Learning: 2026-03-19T07:12:14.508Z
Learnt from: CR
Repo: Aureliolo/synthorg PR: 0
File: CLAUDE.md:0-0
Timestamp: 2026-03-19T07:12:14.508Z
Learning: Applies to src/synthorg/**/*.py : Package structure: src/synthorg/ organized as: api/ (REST+WebSocket, Litestar), auth/ (auth subpackage), backup/ (scheduled/manual backups), budget/ (cost tracking, CFO), cli/ (superseded by Go CLI), communication/ (message bus, meetings), config/ (YAML loading), core/ (domain models, resilience config), engine/ (orchestration, task state, coordination, approval gates, stagnation detection, context budget, compaction), hr/ (hiring, performance, promotion), memory/ (pluggable backend, Mem0, retrieval, consolidation), persistence/ (operational data, SQLite, settings), observability/ (logging, correlation, sinks), providers/ (LLM abstraction, LiteLLM, auth types, presets, runtime CRUD), settings/ (runtime-editable, typed definitions, encryption, config bridge), security/ (SecOps, rule engine, output scanning, progressive trust, autonomy levels), templates/ (company templates, personalities), tools/ (registry, built-in tools, git, sandbox, code_runner, MCP...
Applied to files:
src/synthorg/core/__init__.py
📚 Learning: 2026-03-18T21:23:23.586Z
Learnt from: CR
Repo: Aureliolo/synthorg PR: 0
File: CLAUDE.md:0-0
Timestamp: 2026-03-18T21:23:23.586Z
Learning: Applies to src/synthorg/**/*.py : Event names: always use constants from the domain-specific module under synthorg.observability.events (e.g., API_REQUEST_STARTED from events.api, TOOL_INVOKE_START from events.tool). Import directly from synthorg.observability.events.<domain>.
Applied to files:
src/synthorg/core/__init__.py
🧬 Code graph analysis (8)
tests/unit/core/test_enums.py (1)
web/src/api/types.ts (1)
SkillPattern(847-852)
src/synthorg/templates/loader.py (2)
web/src/api/types.ts (1)
SkillPattern(847-852)src/synthorg/core/enums.py (1)
SkillPattern(175-198)
tests/unit/templates/test_loader.py (1)
src/synthorg/templates/loader.py (2)
load_template(171-227)load_template_file(230-251)
tests/unit/templates/test_schema.py (2)
src/synthorg/core/enums.py (2)
CompanyType(148-158)SkillPattern(175-198)src/synthorg/templates/schema.py (2)
TemplateDepartmentConfig(155-208)TemplateMetadata(211-265)
src/synthorg/templates/schema.py (2)
src/synthorg/core/enums.py (1)
SkillPattern(175-198)web/src/api/types.ts (1)
SkillPattern(847-852)
web/src/api/types.ts (2)
src/synthorg/core/enums.py (1)
SkillPattern(175-198)src/synthorg/api/controllers/setup_models.py (1)
TemplateInfoResponse(36-62)
src/synthorg/core/__init__.py (2)
web/src/api/types.ts (1)
SkillPattern(847-852)src/synthorg/core/enums.py (1)
SkillPattern(175-198)
src/synthorg/core/enums.py (1)
web/src/api/types.ts (1)
SkillPattern(847-852)
🔇 Additional comments (25)
src/synthorg/core/company.py (1)
35-40: Documentation updates are clear and consistent with current validation behavior.These clarifications improve identity/disambiguation semantics without changing runtime behavior.
Also applies to: 50-61, 66-67, 357-365, 379-379
docs/design/operations.md (1)
846-847: Template rename updates look consistent with the new display-name set.tests/unit/core/test_enums.py (1)
27-27:SkillPatternimport wiring is correct.src/synthorg/core/__init__.py (1)
51-52: Public re-export ofSkillPatternis correctly wired.Also applies to: 128-128
docs/design/communication.md (1)
89-90: Archetype mapping rename update is clear and consistent.src/synthorg/api/controllers/setup.py (1)
205-206:/setup/templatescorrectly propagatestagsandskill_patternsinto the API DTO.docs/design/organization.md (1)
14-20: The taxonomy and template-name documentation updates are well-structured and aligned with the feature goals.Also applies to: 26-54
src/synthorg/templates/builtins/research_lab.yaml (1)
3-20: Metadata update is consistent and well-structured.The expanded description, capability-focused tags, and valid
skill_patternsvalues all align with the new taxonomy and discovery goals.src/synthorg/core/enums.py (1)
175-198:SkillPatternenum is clean and correctly defined.The five-member
StrEnumis well-documented and uses stable snake_case values suitable for schema/API typing.src/synthorg/templates/builtins/startup.yaml (1)
3-21: Startup template metadata looks solid.The revised summary, expanded tags, and
skill_patternsclassification are coherent and aligned with the taxonomy rollout.src/synthorg/templates/loader.py (2)
72-83:TemplateInfopropagation is implemented consistently.Both builtin and user template paths now expose
tagsandskill_patternsuniformly throughTemplateInfo.Also applies to: 124-126, 151-153
443-443: Pass-1 normalization correctly includesskill_patterns.Adding
skill_patternsto metadata normalization keeps loader output aligned with schema/API expectations.tests/unit/templates/test_schema.py (1)
188-225: New schema test coverage is strong and targeted.The added cases validate
head_merge_idconstraints andskill_patternsdefault/duplicate handling with clear expectations.Also applies to: 239-260, 279-289
src/synthorg/api/controllers/setup_models.py (1)
49-62:TemplateInfoResponseextension is well-modeled.
extra="forbid"plus typedtagsandskill_patternsprovides a stricter and safer API contract for the new metadata.tests/unit/templates/test_loader.py (2)
151-156: Display-name expectation updates are correct.The assertions now reflect the renamed builtin metadata (
"Solo Builder") while preserving override behavior.Also applies to: 181-182
236-255: Skill-pattern loader tests are comprehensive.The new negative test plus builtin pattern matrix provides good guardrails for validation and taxonomy completeness.
Also applies to: 421-466
src/synthorg/templates/builtins/solo_founder.yaml (1)
2-18: Solo template metadata changes are coherent and safe.The display-name rename, richer summary, updated tags, and
tool_wrapperpattern declaration all fit the intended taxonomy and UX improvements.src/synthorg/templates/builtins/agency.yaml (1)
3-21: Good metadata update and taxonomy mapping.Description, tags, and
skill_patternsare consistent with the template’s workflow and the new discovery taxonomy.src/synthorg/templates/schema.py (2)
198-208:head_merge_idguard is a solid correctness check.The new validator prevents invalid department configs from slipping through and keeps error reporting consistent.
242-265:skill_patternsmodeling and uniqueness validation look correct.Typed enum storage plus duplicate rejection is the right schema-level enforcement for this metadata.
src/synthorg/templates/builtins/full_company.yaml (1)
2-23: Enterprise template metadata is well-aligned with the new taxonomy.The rename, expanded description, tags, and full five-pattern classification are coherent and internally consistent.
web/src/api/types.ts (2)
847-860: Type-level API parity for template metadata looks good.
SkillPatternplusTemplateInfoResponse.skill_patterns/tagskeeps frontend typing aligned with backend payloads.
1007-1008: Department ID field additions are modeled correctly.Using optional nullable fields here is appropriate for partial/legacy payload compatibility.
Also applies to: 1014-1014
src/synthorg/templates/builtins/product_team.yaml (1)
2-21: Strong update for Product Studio metadata.The description, tag specialization, and selected skill patterns are clear and consistent with the template’s flow.
src/synthorg/templates/builtins/dev_shop.yaml (1)
25-25: Nice catch updating the default company name.
company_namenow matches the renamed template and removes stale user-facing text.
| assert "tags" in template | ||
| assert "skill_patterns" in template |
There was a problem hiding this comment.
🧹 Nitpick | 🔵 Trivial
Strengthen API contract assertions for tags and skill_patterns.
Lines 49-50 only check presence. Add shape/value assertions so serialization regressions are caught early.
Proposed assertion upgrades
for template in body["data"]:
assert "name" in template
assert "display_name" in template
assert "description" in template
assert "source" in template
assert "tags" in template
assert "skill_patterns" in template
+ assert isinstance(template["tags"], list)
+ assert all(isinstance(tag, str) for tag in template["tags"])
+ assert isinstance(template["skill_patterns"], list)
+ assert set(template["skill_patterns"]).issubset(
+ {"tool_wrapper", "generator", "reviewer", "inversion", "pipeline"}
+ )🤖 Prompt for AI Agents
Verify each finding against the current code and only fix it if needed.
In `@tests/unit/api/controllers/test_setup.py` around lines 49 - 50, The test
currently only asserts presence of "tags" and "skill_patterns" in the template;
strengthen these to assert concrete shapes and simple value constraints: verify
template["tags"] is a list of non-empty strings (e.g., isinstance(list) and
all(isinstance(t, str) and t.strip() for t in template["tags"])), and verify
template["skill_patterns"] is a list of dict-like objects where each entry
contains expected keys (e.g., "name" and "pattern") with non-empty string values
(e.g., isinstance and non-empty checks). Update the assertions that reference
the template variable in tests/unit/api/controllers/test_setup.py to use these
type/shape/value checks so serialization regressions are caught.
- Add type assertions for tags/skill_patterns in test_template_fields - Add SkillPattern value assertions alongside member count test Co-Authored-By: Claude Opus 4.6 (1M context) <[email protected]>
Aureliolo
temporarily deployed
to
cloudflare-preview
GitHub Actions
Inactive
Aureliolo
temporarily deployed
to
cloudflare-preview
GitHub Actions
Inactive
🤖 I have created a release *beep* *boop* --- ## [0.4.8](v0.4.7...v0.4.8) (2026-03-22) ### Features * add auto_cleanup config and improve update UX ([#741](#741)) ([289638f](289638f)) * add reporting lines, escalation paths, and workflow handoffs to templates ([#745](#745)) ([c374cc9](c374cc9)) * differentiate template operational configs ([#742](#742)) ([9b48345](9b48345)) * diversify personality preset assignments across templates ([#743](#743)) ([15487a5](15487a5)) * improve template metadata -- skill taxonomy, descriptions, tags, and display names ([#752](#752)) ([f333f24](f333f24)) ### Bug Fixes * resolve log analysis findings (Ollama prefix, logging, init) ([#748](#748)) ([8f871a4](8f871a4)) * use git tag for dev release container image tags ([#749](#749)) ([f30d071](f30d071)) * use subordinate_id/supervisor_id in HierarchyResolver ([#751](#751)) ([118235b](118235b)) ### Performance * add long-lived cache headers for content-hashed static assets ([#747](#747)) ([4d350b5](4d350b5)) * use worksteal distribution for pytest-xdist ([#750](#750)) ([b7dd7de](b7dd7de)) --- This PR was generated with [Release Please](https://github.com/googleapis/release-please). See [documentation](https://github.com/googleapis/release-please#release-please).
1 participant
Summary
SkillPatternenum (tool_wrapper,generator,reviewer,inversion,pipeline) based on Google Cloud's five-pattern taxonomy for agent collaborationci-cd,code-review,user-research,data-pipeline, etc.)tagsandskill_patternsthroughTemplateInfo, REST API (TemplateInfoResponse), and TypeScript interfaceSkillPatternuniqueness validator onTemplateMetadataSkillPatternunion type for type-safe frontend usagecommunication.mdandoperations.mdTest plan
TestBuiltinSkillPatterns: 4 tests verifying all builtins have non-empty valid patterns, matrix covers all builtins, and expected patterns matchTestTemplateMetadata:skill_patternsdefaults to(), round-trips with enum values, duplicate patterns rejectedTestLoadTemplateFile: invalid skill pattern in YAML raisesTemplateValidationErrorTestSetupTemplates: API response includestagsandskill_patternsfieldsCloses #698