fix(respond): keep an unusable segmented-reply log base from dropping the reply by Lesereingrape · Pull Request #10231 · AstrBotDevs/AstrBot

Lesereingrape · 2026-09-25T16:58:30Z

platform_settings.segmented_reply.log_base is a dashboard float field (it shows up when 间隔方法 / interval_method is log), and its own hint advertises the range 1.0-10.0 — astrbot/core/config/default.py:4551-4556, copied into every locale, e.g. dashboard/src/i18n/locales/en-US/features/config-metadata.json:1120 ("Base for logarithmic intervals, defaults to 2.6. Value range: 1.0-10.0.").

RespondStage.initialize read it with a bare float() and no domain check, and _calc_comp_interval computes math.log(wc + 1, self.log_base) (astrbot/core/pipeline/respond/stage.py:103). A base of exactly 1 divides by log(1) == 0, so the lower bound the UI recommends raises:

ZeroDivisionError: float division by zero
astrbot/core/pipeline/respond/stage.py:277: in process
astrbot/core/pipeline/respond/stage.py:103: ZeroDivisionError

process() awaits _calc_comp_interval at :277, outside the per-segment try at :279-290, so the exception escapes the send loop and no segment is ever sent — measured on master with a two-Plain-component chain and interval_method: log:

`log_base`	segments delivered
2.6 (default)	2
1.0 (hint's own lower bound)	0, `ZeroDivisionError`
0 (cleared numeric field)	0, `ValueError: math domain error`

The user sees a Prepare to send ... log line and then nothing at all. A base of 0 or a negative number hits the same line through math.log's domain error, and a cleared/hand-edited non-numeric field raises ValueError: could not convert string to float: '' from initialize itself, which breaks pipeline setup for the whole instance.

Modifications / 改动点

Parse the log base through a new _resolve_log_base, which keeps the documented default 2.6 when the value cannot be a logarithm base (<= 0, == 1, non-finite, or unparsable) and logs why, instead of letting the send loop die. This is the same doctrine the interval field eight lines below already uses (Failed to parse the segmented-reply interval: ... → keep the default). Valid values, including the whole rest of the advertised range, are unchanged.
This is NOT a breaking change. / 这不是一个破坏性变更。

Screenshots or Test Results / 运行截图或测试结果

New tests/test_respond_stage_log_base.py (15 cases, repo style with @pytest.mark.asyncio and a SimpleNamespace context, following tests/test_rate_limit_stage.py and tests/test_qqofficial_group_message_create.py): the unusable bases fall back, the usable ones are kept, an unparsable field keeps the default instead of raising, _calc_comp_interval returns a delay at the advertised bound, and process() still delivers both segments there.

On master @ 69ae35a3 (before the change):

FAILED tests/test_respond_stage_log_base.py::test_an_unusable_log_base_falls_back_to_the_default[1]
FAILED tests/test_respond_stage_log_base.py::test_an_unusable_log_base_falls_back_to_the_default[1.0]
FAILED tests/test_respond_stage_log_base.py::test_an_unusable_log_base_falls_back_to_the_default[0]
FAILED tests/test_respond_stage_log_base.py::test_an_unusable_log_base_falls_back_to_the_default[0.0]
FAILED tests/test_respond_stage_log_base.py::test_an_unusable_log_base_falls_back_to_the_default[-2.0]
FAILED tests/test_respond_stage_log_base.py::test_an_unusable_log_base_falls_back_to_the_default[nan]
FAILED tests/test_respond_stage_log_base.py::test_an_unparsable_log_base_keeps_the_default[]
FAILED tests/test_respond_stage_log_base.py::test_an_unparsable_log_base_keeps_the_default[None]
FAILED tests/test_respond_stage_log_base.py::test_an_unparsable_log_base_keeps_the_default[abc]
FAILED tests/test_respond_stage_log_base.py::test_an_unparsable_log_base_keeps_the_default[2,6]
FAILED tests/test_respond_stage_log_base.py::test_the_interval_calculation_survives_the_advertised_lower_bound
FAILED tests/test_respond_stage_log_base.py::test_segmented_reply_is_still_delivered
12 failed, 3 passed in 6.93s

The 3 passes are the usable-base cases, which the change deliberately does not alter. After the change:

15 passed in 5.87s

Regression, Windows / Python 3.12, TESTING=true:

tests/test_respond_stage_log_base.py tests/test_qqofficial_group_message_create.py tests/test_rate_limit_stage.py tests/test_smoke.py
49 passed in 21.56s

pytest tests -q
3534 passed, 82 skipped in 356.93s (0:05:56)

Lint gate (repo-wide job, pinned version):

ruff 0.15.22 check astrbot/core/pipeline/respond/stage.py tests/test_respond_stage_log_base.py -> All checks passed!
ruff 0.15.22 format --check ... -> 2 files already formatted

Docs

No docs/ change: the field keeps its meaning, default and unit, and 1.0 now behaves like "unset" (with a log line) rather than killing delivery. If maintainers would rather reject 1.0 in the dashboard instead, the condition in _resolve_log_base is the one line to move.

Checklist / 检查清单

The boxes below are left unticked on purpose: this patch was prepared by an automated agent session working for the account owner, so the first-person statements are the owner's to confirm, not the agent's. The measured evidence each item would attest to is inline above.

📋 查看中文说明

platform_settings.segmented_reply.log_base 是 Dashboard 里「间隔方法」选 log 时出现的浮点数配置项，其提示文案（astrbot/core/config/default.py:4551-4556，四种语言均已同步）明确写着「取值范围为 1.0-10.0」。但 RespondStage.initialize 只用裸 float() 读取、未校验取值域，而 _calc_comp_interval 在 stage.py:103 计算 math.log(字数 + 1, self.log_base)。底数为 1 时 log(1) == 0，正好触发 ZeroDivisionError——也就是说提示文案推荐的范围下界会让程序崩溃。更糟的是 process() 在 :277 调用它，位置在 :279-290 的逐段 try 之外，异常直接跳出发送循环：实测两段消息链在默认底数 2.6 下发送 2 段，底数为 1.0 或 0 时发送 0 段，用户只看到一行「Prepare to send」此后再无回复。若该字段被清空或手工写成非数字，float('') 会在 initialize 阶段抛错，导致整条 pipeline 初始化失败。本 PR 新增 _resolve_log_base：当底数不可用（≤0、等于 1、非有限值或无法解析）时记录日志并回落到文档默认值 2.6，做法与其下方八行的 interval 字段完全一致；其余合法取值行为不变。新增 15 条用例，修改前 12 failed, 3 passed，修改后 15 passed；相关四文件 49 passed；Windows 全量 3534 passed, 82 skipped；ruff 0.15.22 check/format 均通过。检查清单未勾选是因为该补丁由自动化 agent 会话代为准备，第一人称声明需由账号本人确认，实测证据已附于上文。

Summary by Sourcery

Keep segmented replies deliverable by safely resolving invalid logarithmic interval bases to the default value.

Bug Fixes:

Prevent segmented replies from being dropped when the configured logarithmic interval base is invalid or unparsable by falling back to the documented default.

Tests:

Add regression coverage for invalid and valid log bases, interval calculation at the documented boundary, and delivery of all reply segments.

… the reply

sourcery-ai

Hey - I've found 1 issue

Prompt for AI Agents

Please address the comments from this code review:

## Individual Comments

### Comment 1
<location path="astrbot/core/pipeline/respond/stage.py" line_range="27" />
<code_context>
+    except (TypeError, ValueError) as e:
+        logger.error(f"Failed to parse the segmented-reply log base: {e}")
+        return DEFAULT_LOG_BASE
+    if not math.isfinite(log_base) or log_base <= 0 or log_base == 1:
+        # math.log(words, 1) raises ZeroDivisionError and a non-positive base
+        # raises ValueError; both escape from _calc_comp_interval before the
</code_context>
<issue_to_address>
**issue (bug_risk):** A finite logarithm base between 0 and 1 is accepted, but `_calc_comp_interval` returns a negative value for any nonempty plain message because `log_base(x)` is negative when `x > 1`; `asyncio.sleep` then treats the negative delay as an immediate yield, so segmented replies lose their configured delay.

**Triggers:** When a hand-edited configuration uses a base such as `0.5` and the reply contains more than zero counted words.

**Suggested fix:** Treat `log_base <= 1` as unusable and fall back to `DEFAULT_LOG_BASE`, since the documented interval range starts at 1.0 and delays must be non-negative.

```suggestion
    if not math.isfinite(log_base) or log_base <= 1:
```
</issue_to_address>

Sourcery assessment

Needs a human reviewer. 1 finding to address first, and for an invalid configured base, this changes behavior from dropping the reply to sending segmented messages using the default interval. If that fallback is wrong, reverting prevents future sends but cannot undo messages already delivered externally.

Blocking findings: astrbot/core/pipeline/respond/stage.py:27

Sourcery is free for open source - if you like our reviews please consider sharing them ✨

kilisamemarisaaa

I independently checked the new validation boundary in _resolve_log_base.

A finite base between 0 and 1 is still accepted, for example log_base=0.5. For any non-empty plain component, _calc_comp_interval computes math.log(words + 1, 0.5), which is negative. process() passes that value to asyncio.sleep(); asyncio treats the negative delay as an immediate yield, so segmented replies lose the configured pacing while the setting is silently accepted.

Please classify 0 < base < 1 as unusable and fall back to DEFAULT_LOG_BASE (the proposed condition can be not math.isfinite(log_base) or log_base <= 1). A focused regression should assert the fallback and a non-negative interval for log_base=0.5.

Co-authored-by: sourcery-ai[bot] <58596630+sourcery-ai[bot]@users.noreply.github.com>

sourcery-ai

Sourcery assessment

Approved.

Port 81 compatible upstream patches through fb49dfa. Preserve local chat scrolling, agent extensions, API behavior, and release versions. Adapt queued-request tests to local stage fields and resolve duplicate context arguments. Defer 63aa363 (#10319): plugin Views tests/docs require the excluded Pages-to-Views migration. Validation: - Ruff checks, dashboard typecheck, and production build passed. - Frontend: 1453 passed; 10 failures reproduced on the pre-integration baseline. - Backend: 1091 passed; 2 queue/OpenAPI failures reproduced on the pre-integration baseline. - Backend tests used SQLModel 0.0.31 and SQLAlchemy 2.0.44 in an isolated temporary environment. Upstream commits: 5950d7c chore(deps): bump the github-actions group with 2 updates (#10088) 553096b docs: sync guides with current WebUI navigation (#10093) 763a5ee fix(cron): say who owns a task instead of returning an empty list (#10104) e0aa8d3 fix: clarify local file access menu descriptions 2704b4c fix: tell the model when an animation becomes a frame montage (#10119) bb79c08 fix(dashboard): drop stale exclude_ids hardcode hiding conversations (#10129) f097600 fix(gemini): keep narration streamed before a tool call in history (#10132) 8492df4 fix: serialize Azure TTS backend client lifetimes (#10101) 0812616 fix: propagate Xinference rerank failures instead of returning empty results (#10051) 9c73295 fix: preserve scheduled reminders when an edit is invalid (#10075) 2782454 fix: use GitHub HEAD when repository branch is unspecified (#10080) dae7c24 fix(provider): recognize thinking tags in compatible completions (#10116) b13338d fix(dashboard): restore readable text and switch contrast in fullscreen console (#10135) 774cc94 docs: name the dashboard host/port environment variables and their precedence (#10095) 54c98e8 fix: resolve each OneBot file segment by its own ID (#10098) b065505 fix: clean up invalid materialized images (#10090) 96d9504 docs: explain HTTP proxy address when AstrBot runs in Docker (#10162) 8b5e24b fix: respect session plugin filters in cron agents (#10163) 67c74b7 feat: gzip dashboard static js, css, and html (#10187) 2b6b31a fix: refresh queued conversation history under the session lock (#10238) fbf5286 feat: forward extra_user_content_parts through Context.tool_loop_agent (#10237) 559b171 fix(weixin_oc): keep a cleared timeout field from disabling the HTTP timeout (#10229) 14835b5 fix(respond): keep an unusable segmented-reply log base from dropping the reply (#10231) a426808 fix: skip queued LLM requests after disabling (#10234) 61ba3a2 fix: estimate emoji token cost above the plain text rate (#10216) 0531575 fix: increase cron misfire grace time to 300 seconds (#10183) 42ad277 chore(deps): bump the github-actions group with 4 updates (#10184) 1a59156 feat(dashboard): add search to Skills and MCP pages (#10217) 5fcaf69 fix: compare platform message history cutoff in UTC (#10246) c8a07f7 fix(platform): keep the Satori heartbeat and reconnect delays from being disabled by a cleared field (#10248) ae5a155 fix(dashboard): fix dark mode icons and platform template order (#10061) e99432c fix(qqofficial): restore @ mentions in group messages (#9705) 5b04f13 perf: skip state allocation when rate limiting is disabled (#10270) e19954b fix(stats): prevent timers from starting after unmount (#10272) 1c5dd91 perf(session): skip unused alias lookup when listing rules (#10273) 9c6b603 perf(trace): sort records only for updated spans (#10274) b53999e fix: support Windows long paths during plugin archive extraction (#10193) 5a4745f docs: rename dev QQ group to chit-chat group and add community email (#10282) fe29538 fix: update remaining legacy AstrBot icons (#10278) 6d50e1e chore(deps): bump github/codeql-action in the github-actions group (#10265) ac515d9 docs: add slider key to plugin dev docs (#10289) 73b4fc9 fix: correct shields.io badge links in README files (#10290) 6a2186b fix: replace DeepWiki badge with shields.io in README files (#10299) 553b10f fix(dashboard): use the primary color for the config test-chat button (#10309) 9d4f523 feat(dashboard): edit config profiles from a side drawer in the bot editor (#10310) 9f65a01 fix: reuse logo tokens and refresh expired platform cache (#10294) ab7de72 feat(dashboard): add log search and keyword highlighting to console (#10327) d399090 fix(webui): use colored DeepSeek provider icon (#10332) a6265fa fix: degrade unresolvable voice attachments instead of failing the turn (#10337) 1245979 fix(dashboard): enforce session ownership on chat send path (#10346) 44b5c1b feat(dashboard): show source badge for skills in skills list (#10339) 95af435 fix(dashboard): restore plugin README anchor navigation (#10341) 3d80dd3 fix: clean up session waiter registrations only once (#10344) (#10347) ac4df99 fix(dashboard): align fullscreen log search with dark theme (#10351) 6a4decd fix: handle UTF-16 offsets in Telegram mentions (#10367) f7f3c71 fix: leave Telegram bot token empty by default (#10365) 2f889d2 fix: preserve child folders when deleting persona folders (#10361) de31bbe fix: close FishAudio TTS HTTP client after requests (#10358) 4c037c4 fix: resolve remote Slack file URLs before upload (#10355) dfaaca1 docs: update Slack setup steps and screenshot (#10353) 3861730 fix(telegram): match bot mentions case-insensitively (#10399) 57ac1d8 fix: preserve Slack code block and quote text (#10380) 64430fa docs: sync Lark/Feishu guide with current capabilities and permissions (#10400) c1356bb fix(dify): handle CRLF event separators in streaming responses (#10392) 900a700 fix: match command group names as whole words (#10372) 55c2dd3 feat: remember the last opened tab on the Data & Logs page (#10251) e1d30f3 fix(provider): replace retired gemini-embedding-exp-03-07 default with gemini-embedding-001 (#10393) 2de9059 fix: avoid blocking audio format probes (#10055) 65cbe98 feat: ship astrbot CLI in Docker image for in-container password reset (#10442) cae8f1d feat(dashboard): add distinct hints for local permission access modes (#10444) 30820a4 fix(provider): keep Anthropic tool calls whose streamed input is empty (#10432) 6b2e417 fix(provider): merge custom server tools with registered tools in Anthropic requests (#10437) d8ef9dd fix: send Discord video components as attachments (#10423) 5994167 fix: preserve links and mentions in Slack lists (#10447) 03ce652 fix: preserve outbound Slack user mentions (#10448) d2fb912 fix: prevent Discord self-reply loops (#10425) b01285a chore(github): add plugin submission links to issue template config (#10455) c6f4150 fix: avoid recording cron sends without a matching platform (#10468) 28a10c1 fix: warn when a background task result is not sent to the user (#10398) 845517e chore(github): update plugin submission links in issue template config (#10472) fb49dfa fix(dashboard): update plugin market submit link and label (#10471)

fix(respond): keep an unusable segmented-reply log base from dropping…

f968252

… the reply

sourcery-ai Bot reviewed Sep 25, 2026

View reviewed changes

Comment thread astrbot/core/pipeline/respond/stage.py Resolved

kilisamemarisaaa suggested changes Sep 27, 2026

View reviewed changes

Soulter and others added 2 commits September 27, 2026 11:10

Update astrbot/core/pipeline/respond/stage.py

00bb72a

Co-authored-by: sourcery-ai[bot] <58596630+sourcery-ai[bot]@users.noreply.github.com>

Delete tests/test_respond_stage_log_base.py

aa3daa9

Soulter approved these changes Sep 27, 2026

View reviewed changes

sourcery-ai Bot approved these changes Sep 27, 2026

View reviewed changes

Soulter merged commit 14835b5 into AstrBotDevs:master Sep 27, 2026
22 checks passed

Lesereingrape mentioned this pull request Sep 27, 2026

fix(core): keep a one-item segmented-reply interval from dropping the whole reply #10254

Closed

1 task done

BegoniaHe mentioned this pull request Oct 19, 2026

[chore] upstream sync: ledger completeness gaps and stale test commands Xero-Team/AstrBot#363

Closed

8 tasks

Soulter added this to AstrBot Roadmap Nov 2, 2026

Soulter moved this to Done in AstrBot Roadmap Nov 2, 2026

Navigation Menu

Repository navigation

fix(respond): keep an unusable segmented-reply log base from dropping the reply - #10231

fix(respond): keep an unusable segmented-reply log base from dropping the reply#10231
Soulter merged 3 commits into
AstrBotDevs:masterfrom
Lesereingrape:fix/segmented-reply-log-base-domain

Lesereingrape commented Sep 25, 2026 •

edited by sourcery-ai Bot

Loading

Uh oh!

sourcery-ai Bot left a comment

Uh oh!

Uh oh!

kilisamemarisaaa left a comment

Uh oh!

sourcery-ai Bot left a comment

Uh oh!

Uh oh!

Reviewers

Uh oh!

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

Conversation

Lesereingrape commented Sep 25, 2026 • edited by sourcery-ai Bot Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Modifications / 改动点

Screenshots or Test Results / 运行截图或测试结果

Docs

Checklist / 检查清单

Summary by Sourcery

Uh oh!

sourcery-ai Bot left a comment

Choose a reason for hiding this comment

Sourcery assessment

Uh oh!

Uh oh!

kilisamemarisaaa left a comment

Choose a reason for hiding this comment

Uh oh!

sourcery-ai Bot left a comment

Choose a reason for hiding this comment

Sourcery assessment

Uh oh!

Uh oh!

Reviewers

Uh oh!

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

Lesereingrape commented Sep 25, 2026 •

edited by sourcery-ai Bot

Loading