fix: rest parameter crash resolver#2748
Merged
HerrCai0907 merged 3 commits intoAssemblyScript:mainfrom Oct 7, 2023
Merged
Conversation
CountBleck
reviewed
Sep 27, 2023
Member
CountBleck
left a comment
CountBleck
left a comment
There was a problem hiding this comment.
The change in resolver.ts looks fine, but can't more functionality be tested (i.e. calling the function with 0-3 arguments)? If there are crashes from that, those should become errors.
Member
|
@HerrCai0907 Try |
HerrCai0907
force-pushed
the
fix/#2707
branch
from
cd2a7a8 to
24792b1
Compare
Member
Author
It is invalid code in current AS. rest parameter is not supported yet. |
CountBleck
reviewed
Oct 1, 2023
Member
CountBleck
left a comment
CountBleck
left a comment
There was a problem hiding this comment.
There should be a func(1, 2, 3, 4) in the test. Then, the presence of the "Not implemented: Rest parameters" error can be checked in the stderr (and the 2707.{debug,release}.wat should be removed).
CountBleck
approved these changes
Oct 3, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #2707