You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Updates Binaryen to latest nightly, including the relevant API changes.
Note that this is broken right now, in that std/map and std/set fail to optimize with a RuntimeError: null function or function signature mismatch, indicating that something is off. Error message is the same as reported in #2682.
The other PR seems to address stack overflows in setMemory only, where previously all the data segments were allocated on the stack, easily overflowing it, hence proposing that these are instead allocated on the heap. The issues seen here, however, appear to happen during optimizations, more precisely in chains of PrecomputingExpressionRunner::visit that overflow the stack. From a quick glimpse, what happens is that visitBinary for example creates additional expression runners, incl. for LHS and RHS, so if there are sufficiently nested binaries within binaries for instance, the stack overflows. Makes me wonder, rather, whether the design of expression runners can be improved, since even if we increase stack size x10, this doesn't prevent that x10 complex nested expressions still overflow the stack. Some additional details in WebAssembly/binaryen#5648.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Updates Binaryen to latest nightly, including the relevant API changes.
Note that this is broken right now, in thatstd/mapandstd/setfail to optimize with aRuntimeError: null function or function signature mismatch, indicating that something is off. Error message is the same as reported in #2682.