Fix the bindings for performance.now() and document.*#2657
Merged
dcodeIO merged 1 commit intoAssemblyScript:mainfrom Apr 23, 2023
Merged
Fix the bindings for performance.now() and document.*#2657dcodeIO merged 1 commit intoAssemblyScript:mainfrom
dcodeIO merged 1 commit intoAssemblyScript:mainfrom
Conversation
Member
Author
|
On a related note, does AS's |
Member
|
Hmm, it should be a default behavior until |
Member
Author
|
What about, say, importing functions from Wasm that return |
This change should ensure performance.now() and document.foo() does not break.
CountBleck
force-pushed
the
fix-performance-now
branch
from
65ce44b to
ab678e7
Compare
Member
Author
|
This PR should also fix #2692 (I hope). |
dcodeIO
approved these changes
Apr 23, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
performance.now()and co. need to be called with the proper this value.Changes proposed in this pull request:
⯈ Ensure
performance.now()is called properly.⯈ Ensure
document.*is called properly.