allow addMemory to support 65536 wasm pages memory#2654
Merged
dcodeIO merged 4 commits intoAssemblyScript:mainfrom Apr 25, 2023
Merged
allow addMemory to support 65536 wasm pages memory#2654dcodeIO merged 4 commits intoAssemblyScript:mainfrom
addMemory to support 65536 wasm pages memory#2654dcodeIO merged 4 commits intoAssemblyScript:mainfrom
Conversation
Member
Author
dcodeIO
reviewed
Apr 24, 2023
HerrCai0907
force-pushed
the
rt-addMemory
branch
from
e86bce7 to
c0cdd1d
Compare
dcodeIO
approved these changes
Apr 25, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
If wasm uses 65536 pages memory, memory.size() << 16 will be 0 due to overflow.
It causes
assert(start <= end)failed. (end is 0)Actually due to assemblyscript runtime will double the memory each time. It will happened when wasm uses 32768 page and want to grow memory.
This PR wants to avoid this assert failed when wasm use 65536 pages.
fixed: #2653