Support supplementary CPs in Unicode identifiers#2522
Merged
Conversation
2 tasks
dcodeIO
commented
Sep 26, 2022
MaxGraey
reviewed
Sep 26, 2022
MaxGraey
reviewed
Sep 26, 2022
Comment on lines
+37
to
+38
| console.log(`const unicodeIdentifierStartMin = ${starts[0]};`); | ||
| console.log(`const unicodeIdentifierStartMax = ${starts[starts.length - 1]};\n`); |
Member
There was a problem hiding this comment.
Suggested change
| console.log(`const unicodeIdentifierStartMin = ${starts[0]};`); | |
| console.log(`const unicodeIdentifierStartMax = ${starts[starts.length - 1]};\n`); | |
| console.log(`const UnicodeIdentifierStartMin = ${starts[0]};`); | |
| console.log(`const UnicodeIdentifierStartMax = ${starts[starts.length - 1]};\n`); |
Member
Author
There was a problem hiding this comment.
Using title case for SomeEnum.SomeValue seems fine, but just SomeValue conflicts visually with classes, enums and interfaces. Not sure it's preferable?
MaxGraey
reviewed
Sep 26, 2022
MaxGraey
reviewed
Sep 26, 2022
MaxGraey
reviewed
Sep 26, 2022
MaxGraey
reviewed
Sep 26, 2022
dcodeIO
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Showed up in #2495, where 4-byte Unicode characters are not accepted as identifier starts/parts by the tokenizer. In TS, there exist maps for ES3, ES5 and ESNext, and I assume our current one matches the ES5 one. This PR adds a script we can use to generate the tables for ESNext (respectively: current Unicode tables used by Node), which should be the only relevant maps for us.
On our end, the respective maps are here. For ESNext, we'll need to go from
u16tou32since these values are codepoints.