Skip to content

Commit 98fa286

Browse files
committed
fix: deny bash commands with arguments when command name matches rule
Fixes anomalyco#7063 When evaluating bash permissions, the system now checks both: 1. The full command pattern (e.g., 'yarn test') 2. The command name (first word, e.g., 'yarn') This ensures that when a user configures 'yarn: deny', commands like 'yarn test', 'yarn install', etc. are correctly denied, not just the exact 'yarn' command. The fix modifies the evaluate() function to extract the first word of bash commands and check if it matches any deny rules, preventing permission bypass via command arguments.
1 parent e9ce27c commit 98fa286

2 files changed

Lines changed: 84 additions & 3 deletions

File tree

‎packages/opencode/src/permission/next.ts‎

Lines changed: 9 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -220,9 +220,15 @@ export namespace PermissionNext {
220220
export function evaluate(permission: string, pattern: string, ...rulesets: Ruleset[]): Rule {
221221
const merged = merge(...rulesets)
222222
log.info("evaluate", { permission, pattern, ruleset: merged })
223-
const match = merged.findLast(
224-
(rule) => Wildcard.match(permission, rule.permission) && Wildcard.match(pattern, rule.pattern),
225-
)
223+
const match = merged.findLast((rule) => {
224+
if (!Wildcard.match(permission, rule.permission)) return false
225+
if (Wildcard.match(pattern, rule.pattern)) return true
226+
if (permission === "bash") {
227+
const cmd = pattern.split(/\s+/)[0]
228+
if (cmd && Wildcard.match(cmd, rule.pattern)) return true
229+
}
230+
return false
231+
})
226232
return match ?? { action: "ask", permission, pattern: "*" }
227233
}
228234

‎packages/opencode/test/permission/next.test.ts‎

Lines changed: 75 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -417,6 +417,81 @@ test("disabled - specific allow overrides wildcard deny", () => {
417417
expect(result.has("read")).toBe(true)
418418
})
419419

420+
// bash command name matching tests (Issue #7063)
421+
422+
test("evaluate - bash denies command with args when command name matches deny rule", () => {
423+
const result = PermissionNext.evaluate("bash", "yarn test", [{ permission: "bash", pattern: "yarn", action: "deny" }])
424+
expect(result.action).toBe("deny")
425+
})
426+
427+
test("evaluate - bash denies npm install when npm is denied", () => {
428+
const result = PermissionNext.evaluate("bash", "npm install", [
429+
{ permission: "bash", pattern: "npm", action: "deny" },
430+
])
431+
expect(result.action).toBe("deny")
432+
})
433+
434+
test("evaluate - bash denies pnpm run build when pnpm is denied", () => {
435+
const result = PermissionNext.evaluate("bash", "pnpm run build", [
436+
{ permission: "bash", pattern: "pnpm", action: "deny" },
437+
])
438+
expect(result.action).toBe("deny")
439+
})
440+
441+
test("evaluate - bash denies npx create-react-app when npx is denied", () => {
442+
const result = PermissionNext.evaluate("bash", "npx create-react-app myapp", [
443+
{ permission: "bash", pattern: "npx", action: "deny" },
444+
])
445+
expect(result.action).toBe("deny")
446+
})
447+
448+
test("evaluate - bash command name match does not affect non-bash permissions", () => {
449+
const result = PermissionNext.evaluate("edit", "yarn test", [
450+
{ permission: "edit", pattern: "yarn", action: "deny" },
451+
])
452+
expect(result.action).toBe("ask")
453+
})
454+
455+
test("evaluate - bash allows command when no deny rule exists", () => {
456+
const result = PermissionNext.evaluate("bash", "yarn test", [
457+
{ permission: "bash", pattern: "*", action: "allow" },
458+
])
459+
expect(result.action).toBe("allow")
460+
})
461+
462+
test("evaluate - bash exact pattern still works", () => {
463+
const result = PermissionNext.evaluate("bash", "yarn", [{ permission: "bash", pattern: "yarn", action: "deny" }])
464+
expect(result.action).toBe("deny")
465+
})
466+
467+
test("evaluate - bash wildcard pattern takes precedence over command name match", () => {
468+
const result = PermissionNext.evaluate("bash", "yarn test", [
469+
{ permission: "bash", pattern: "yarn", action: "deny" },
470+
{ permission: "bash", pattern: "*", action: "allow" },
471+
])
472+
expect(result.action).toBe("allow")
473+
})
474+
475+
test("evaluate - bash command name deny after wildcard allow", () => {
476+
const result = PermissionNext.evaluate("bash", "yarn test", [
477+
{ permission: "bash", pattern: "*", action: "allow" },
478+
{ permission: "bash", pattern: "yarn", action: "deny" },
479+
])
480+
expect(result.action).toBe("deny")
481+
})
482+
483+
test("evaluate - bash with multiple denied commands", () => {
484+
const rules: PermissionNext.Ruleset = [
485+
{ permission: "bash", pattern: "yarn", action: "deny" },
486+
{ permission: "bash", pattern: "npm", action: "deny" },
487+
{ permission: "bash", pattern: "pnpm", action: "deny" },
488+
]
489+
expect(PermissionNext.evaluate("bash", "yarn install", rules).action).toBe("deny")
490+
expect(PermissionNext.evaluate("bash", "npm run test", rules).action).toBe("deny")
491+
expect(PermissionNext.evaluate("bash", "pnpm add lodash", rules).action).toBe("deny")
492+
expect(PermissionNext.evaluate("bash", "ls -la", rules).action).toBe("ask")
493+
})
494+
420495
// ask tests
421496

422497
test("ask - resolves immediately when action is allow", async () => {

0 commit comments

Comments
 (0)