You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
{{ message }}
Repository navigation
Commit 9ebab62
Browse filesBrowse the repository at this point in the historyBrowse files
fix: Enable sliding window execution for covar_pop, covar_samp, and corr (apache#22764)
## Which issue does this PR close?
- Closesapache#22763 .
## Rationale for this change
Bounded sliding window queries using `covar_pop`, `covar_samp`, and
`corr` currently fail with a `retract_batch is not implemented` error,
preventing these aggregates from being used with sliding window frames.
## What changes are included in this PR?
* Included `supports_retract_batch()` for the covariance and correlation
accumulators.
* Added SQL logic tests covering bounded sliding window execution for
covariance and correlation aggregates.
## Are these changes tested?
Yes.
Added SQL logic tests covering:
* Single-row bounded sliding frames
* Multi-row bounded sliding frames
for `covar_pop`, `covar_samp`, and `corr`.
## Are there any user-facing changes?
Yes.
`covar_pop`, `covar_samp`, and `corr` can now be used with bounded
sliding window frames that previously failed. Also, no changes were made
to any public APIs.
(cherry picked from commit 37768b8)
0 commit comments