-
Notifications
You must be signed in to change notification settings - Fork 29
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add fallback when API call fails. #36
Conversation
Excellent Can you help record these three ~5-10sec screenrecording gifs, we'll use them for the new docs:
I like this app, but there are many others too that can make GIFs easily: https://gifox.app/ |
@pirate For people using 0.7.3, how should we handle auth? Should we add fields to the config UI to let them set the username and password, just like with the API key? |
You should be able to just make a request to /add with the browser's existing cookies, you can see how the current codebase does it on the main branch. |
The logic used to require that an API key was set in the extension configuration even if version 0.7.3 was being used.
Awesome, thanks! Rendering bug is due to narrow(ish) screen width, I only bothered to write the CSS for wide desktop screens and mobile, with nothing in between 😅. |
This PR adds a fallback in case the user is running an ArchiveBox version without a REST API (pre v0.8.0).