Redesign fixes #34
Merged
Redesign fixes #34
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Also fix closing popup when pressing escape.
Also cleaned up now unused code from popup.js.
pirate
approved these changes
Dec 13, 2024
redesign/popup.js
Outdated
Comment on lines
39
to
40
| url: archivebox_server_url, | ||
| apiKey: archivebox_api_key, |
There was a problem hiding this comment.
Suggested change
| url: archivebox_server_url, | |
| apiKey: archivebox_api_key, |
Delete these lines too above:
- const { archivebox_server_url, archivebox_api_key } = await chrome.storage.local.get([
- 'archivebox_server_url',
- 'archivebox_api_key'
- ]);There was a problem hiding this comment.
Don't forget to delete the dead code above here.
Co-authored-by: Nick Sweeting <[email protected]>
|
LGTM. thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
These changes (along with a small bug fix in the main ArchiveBox repo) let the extension successfully make a request to a running ArchiveBox server.
This was tested with
v0.8.5rc51The request to the REST API is made from the background script, instead of the popup script, to avoid having to deal with CORS issues.
I'm not doing anything with the response from the fetch request for now, but we could probably have an indicator that updates to show that the snapshot was successful.
It seems like the
content_scriptssection of themanifest.jsonwas superfluous, and led to errors loading the extension for me, so I removed it.