Added TAG_SEPARATOR_PATTERN option for splitting tags #911
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…en splitting tags
|
This looks awesome, thanks for working on it! One small note: If it's a REGEX we should probably change the name from |
hannah98
changed the title
|
Understood. I have updated the code to rename TAG_SEPARATORS to TAG_SEPARATOR_PATTERN. |
pirate
reviewed
Jan 11, 2022
|
Oops You're right I haven't updated it yet, the configuration page is a bit behind. It used to be publicly editable but some people abused it by adding virus links all over, so I had to lock it down. Unfortunately I don't know if there's a way to accept PRs for the wiki? If anyone wants to contribute to wiki, I can just copy paste suggestions in from comments here and commit them myself. |
30 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
This PR adds the
TAG_SEPARATOR_PATTERNoption. This option is a regex character class that will be used when splitting the tag string.It defaults to
[,]which will split tags on commas. Splitting tags is currently done on commas so this will be backwards compatible and should not introduce breaking changes.Some Examples:
TAG_SEPARATOR_PATTERN="[ ]"TAG_SEPARATOR_PATTERN="[ ,]"TAG_SEPARATOR_PATTERN="[ ,;]"Related issues
#725
Changes these areas