Poc setup django on init #515
Conversation
cdvv7788
force-pushed
the
POC-setup-django-on-init
branch
from
5b9fd53 to
f6ce1de
Compare
|
These commands in need to work in a non-data folder, make sure to test them with this PR: cd /tmp
archivebox version
archivebox help
archivebox oneshot
archivebox initAlso make sure to check the whole init process in general, I ran into some trouble earlier trying to use v0.4.21 to read a collection, so I want to make sure this PR fixes that issue: ➜ ~/D/o/A/data ⨈(data) ⎇ (master) ❈5 # ll
> /Users/squash/Documents/opt/ArchiveBox/data
drwxr-xr-x - squash staff 2020-10-25 21:01 -- .venv/
drwxr-xr-x - squash staff 2020-09-11 12:51 -- archive/
drwxr-xr-x - squash staff 2020-08-01 11:44 -- data/
drwxr-xr-x - squash staff 2020-08-18 02:04 -- logs/
drwxr-xr-x - squash staff 2020-10-24 22:50 -- node_modules/
drwxr-xr-x - squash staff 2020-09-11 12:51 -- sources/
drwxr-xr-x - squash staff 2020-08-18 00:53 -- static/
.rwxr-xr-x@ 0 squash staff 2020-10-24 22:47 -- 2020-10-25_index_old.html*
.rwxr-xr-x 869k squash staff 2020-09-11 12:51 -- 2020-10-25_index_old.json*
.rw-------@ 81 squash staff 2020-10-24 22:47 -- ArchiveBox.conf
.rwxr-xr-x 82 squash staff 2020-10-24 22:47 -- ArchiveBox.conf.bak*
.rwxr-xr-x 15k squash staff 2020-09-11 12:51 -- favicon.ico*
.rw-r--r--@ 302k squash staff 2020-10-24 22:48 -- index.html
.rwxr-xr-x 409k squash staff 2020-10-24 22:47 -- index.sqlite3*
.rw-r--r-- 86k squash staff 2020-10-24 22:50 -- package-lock.json
.rwxr-xr-x 30 squash staff 2020-09-11 12:51 -- robots.txt*
➜ ~/D/o/A/data ⨈(data) ⎇ (master) ❈5 # archivebox help
Welcome to ArchiveBox v0.4.21!
To import an existing archive (from a previous version of ArchiveBox):
1. cd into your data dir OUTPUT_DIR (usually ArchiveBox/output) and run:
2. archivebox init
To start a new archive:
1. Create an empty directory, then cd into it and run:
2. archivebox init
For more information, see the documentation here:
https://github.com/pirate/ArchiveBox/wiki
➜ ~/D/o/A/data ⨈(data) ⎇ (master) ❈5 # archivebox init
[i] [2020-10-28 00:48:29] ArchiveBox v0.4.21: archivebox init
> /Users/squash/Documents/opt/ArchiveBox/data
[X] This folder appears to already have files in it, but no index.json is present.
You must run init in a completely empty directory, or an existing data folder.
Hint: To import an existing data folder make sure to cd into the folder first,
then run and run 'archivebox init' to pick up where you left off.
(Always make sure your data folder is backed up first before updating ArchiveBox)
[2](its not recognizing the collection on 0.4.21, and it wont let me init to update it because it cant find |
|
@pirate you are trying to run init in an archive that has been updated to v0.5. What do you expect to happen in this case? Should it look for the _index_old.json and try to copy them to |
|
It should throw an error if the version in the DB is greater than / incompatible the version being run, rather than claiming there is no index in the current folder. |
|
However, that should be a hotfix in the v0.4 branch, right? That would belong to another PR. I can add that to the current version, but your case will not be supported that way unless we merge it back there too. |
|
@pirate for the fix you want, you want v0.4 to recognize if the index is of v0.5, right? Should I send a PR to that version's branch directly? |
|
Nah we should just add the check to the current version, without patching 0.4. It will be useful only starting in the next release with v0.6. |
Summary
Initializing django on cli init, and removing it from internal functions.
The in-memory database may be required at a later point (when we start saving the ArchiveResults to the database) but at this point, this seems to work and no test is broken. Maybe we can remove all of the
setup_djangocalls in this PR and work with that as a basis for the next iteration. WDYT @pirate ?Related issues #496 #510
Changes these areas