setup_django changes #510
Closed
setup_django changes #510
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pirate
reviewed
Oct 24, 2020
| @@ -129,6 +129,14 @@ | |||
| FAVICON_FILENAME, | |||
| } | |||
|
|
|||
|
|
|||
| def using_django(func): | |||
There was a problem hiding this comment.
this is cool but I think it's too "magic" for not much gain. easier to just keep it as a function call at the top of all the ones that need it.
def add(urls: Union[str, List[str]], out_dir: Path):
setup_django(out_dir=our_dir, check_db=True)
...
|
I have an idea, what if we initialize Django always, but if it's not in a data dir, we use a fake database in memory instead. This also lets us do
DATABASE_FILE = Path(OUTPUT_DIR) / SQL_INDEX_FILENAME
DATABASES = {
'default': {
'ENGINE': 'django.db.backends.sqlite3',
'NAME': str(DATABASE_FILE) if DATABASE_FILE.exists() else ':memory:',
}
} |
|
Superseded by #515 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Refactor the way django is setup in the application
Related issues #496
Changes these areas