-
-
Notifications
You must be signed in to change notification settings - Fork 1.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
#399 Singlefile support #403
Conversation
@pirate This first version is functional but it is lacking a lot of flexibility. It uses the It currently works, if you have chrome installed. It creates a new file in the archive named |
A good start, things left:
|
|
@pirate please review. I think we can close this and add the new config options to the cli in another PR. Let me know if you prefer adding that in here. |
The last thing remaining is to add it to the docker image so it works out-of-the-box. |
@pirate Added a fixture to the tests to avoid using methods we were not actually testing. By default it will bypass all the extractors. The python tests should be running faster now because of this change. |
Summary
Add https://github.com/gildas-lormeau/SingleFile as an extractor
**Related issues: #399
Changes these areas