Update to Django 4.2.x #1388
Update to Django 4.2.x #1388
Conversation
|
Wow, amazing! Thank you so much, what a dream PR to receive as a maintainer! I'll merge it immediately even if there's stuff to fix, as I want to rebase all my other dev work on this ASAP. I'm so ready to leave 3.1 behind and get everyone on modern Django, I let it fall behind for too long! |
|
had this today. container in endeless loop (as docker swarm is trying to recreate the failed container [i] [2024-03-27 17:41:51] ArchiveBox v0.7.3: archivebox server --quick-init 0.0.0.0:8000 Traceback (most recent call last): File "/usr/local/bin/archivebox", line 8, in File "/app/archivebox/cli/init.py", line 140, in main File "/app/archivebox/cli/init.py", line 74, in run_subcommand File "/app/archivebox/config.py", line 1425, in setup_django File "/usr/local/lib/python3.11/site-packages/django/init.py", line 24, in setup File "/usr/local/lib/python3.11/site-packages/django/apps/registry.py", line 124, in populate File "/app/archivebox/core/apps.py", line 8, in ready File "/app/archivebox/core/auth.py", line 3, in ImportError: attempted relative import beyond top-level package |
|
This was mentioned in the pull request, there's another commit that needs to be pulled in from a WIP branch of @pirate's. |
Summary
This updates Django to 4.2.x, which is currently in LTS until April 2026, and away from 3.1.x which is no longer supported.
More changes may be required.
I had to stub out the LDAP stuff in(This commit fixes the LDAP issue that I had.)archivebox/core/auth.pyto get it to run locally (but did not commit this) because ofImportError: attempted relative import beyond top-level packageerrors. I'm not sure I understand the dependencies there, but it seems like LDAP configuration should get passed into the Django app rather than it trying to import it from outsidecore.This didn't cause any additional tests to fail for me, and some cursory poking around the UI didn't turn up any problems.
The change to
archivebox/core/admin.pyis less significant than it appears because it's really just moving theAdminSitesubclass above theModelAdminsubclasses so the@admin.register(..., site=archivebox_admin)works. Maybe it would be an opportunity to split these admin classes into a package.Related issues
I have no idea if this fixes any reported issues, but probably not. I assume some new features come from updating Django, but I don't know enough to even suggest what those might be.
Changes these areas