Make "DOCS" link in navigation bar open in new tab #1323
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
change navigation template so docs link opens in new tab
|
good idea, thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Proposal to have navigation template so DOCS link open in new tab
Summary
I'm working with ArchiveBox for the first time, and looking extensively at the Docs as I do (and enjoying it - thanks!).
I've found it disruptive that the Docs link opens in the same tab: invariably if I want to read docs, I want to do so alongside the application. I realised that this is quite an easy thing to fix by changing the html template, and thought I'd propose it.
Side-note
This is my first pull request, so I'm paranoid that I'm doing it wrong. Please bear that in mind when reviewing.
Changes these areas