Show the upgrade notification only in specific views #1314
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Can you post a screenshot of what this looks like in the UI? |
|
Here's what it looks like for me: |
|
Awesome, thanks. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
This PR adds back the upgrade notification banner that was originally added in #1274 and removed in 4af9bee, but only to specific views instead of the entire admin site, as discussed in #1306.
I wasn't sure for which views we should show the banner, so for now it's only showing on the snapshot view (the page at
/admin/core/snapshot/.The necessary context is provided by overriding the
changelist_viewmethod of theSnapshotAdminmodel. I think this could work for all views except for the main admin page (/admin/). If we want to pass context to the view for that page, I think we can override theeach_contextmethod ofArchiveBoxAdmininstead.Related issues
#696
Changes these areas