Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Show banner and hints to upgrade when ArchiveBox is out of date #1274

Merged
merged 13 commits into from
Dec 19, 2023
Merged

Show banner and hints to upgrade when ArchiveBox is out of date #1274

merged 13 commits into from
Dec 19, 2023

Conversation

benmuth
Copy link
Contributor

@benmuth benmuth commented Nov 23, 2023 •
edited
Loading

Summary

  • adds a dismissable banner notifying admin users about newly available versions of ArchiveBox
  • adds hints to upgrade to add and schedule jobs in the CLI

Related issues

#696

Changes these areas

  • Bugfixes
  • Feature behavior
  • Command line interface
  • Configuration options
  • Internal architecture
  • Snapshot data layout on disk

@benmuth benmuth changed the title Add notification about upgrade to admin page Show banner and hints to upgrade ArchiveBox Nov 28, 2023
@benmuth benmuth changed the title Show banner and hints to upgrade ArchiveBox Show banner and hints to upgrade when ArchiveBox is out of date Nov 28, 2023
@benmuth benmuth marked this pull request as ready for review November 28, 2023 05:33
pirate
pirate requested changes Nov 28, 2023
View reviewed changes
Copy link
Member

@pirate pirate left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, just some small comments

@benmuth benmuth requested a review from pirate December 1, 2023 23:11
@pirate
Copy link
Member

pirate commented Dec 19, 2023

made some changes, take a look at my commits

@pirate pirate merged commit b03ece4 into ArchiveBox:dev Dec 19, 2023
@benmuth benmuth mentioned this pull request Jan 9, 2024
Merged
6 tasks
@benmuth benmuth deleted the version-banner branch March 15, 2024 23:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@pirate pirate Awaiting requested review from pirate

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@benmuth @pirate