Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add config options to initialize admin user on first run without prompting #1245

Merged
merged 5 commits into from
Oct 18, 2023
Merged

Add config options to initialize admin user on first run without prompting #1245

merged 5 commits into from
Oct 18, 2023

Conversation

benmuth
Copy link
Contributor

@benmuth benmuth commented Oct 14, 2023

Summary

This adds the option to create an admin user on initialization without prompting. The configuration options ARCHIVEBOX_USERNAME and ARCHIVEBOX_PASSWORD are only checked on first initialization (if there's no index.sqlite3 file). The admin user is only created if both options are present.

I'm not sure if there are some other use cases that exist that are not covered by this implementation, please let me know if so.

Related issues

#734

Changes these areas

  • Bugfixes
  • Feature behavior
  • Command line interface
  • Configuration options
  • Internal architecture
  • Snapshot data layout on disk

@benmuth benmuth changed the title Add config options to add admin user on first run Add config options to initialize admin user on first run without prompting Oct 14, 2023
github-advanced-security[bot]
github-advanced-security bot found potential problems Oct 14, 2023
View reviewed changes
@benmuth benmuth marked this pull request as ready for review October 14, 2023 21:42
@pirate
Copy link
Member

pirate commented Oct 16, 2023

Looks good! Two small changes:

  1. Let's change it to ADMIN_USERNAME and ADMIN_PASSWORD
  2. Can you check if a user with the ADMIN_USERNAME already exists and skip creating it in that case

github-advanced-security[bot]
github-advanced-security bot found potential problems Oct 18, 2023
View reviewed changes
pirate
pirate requested changes Oct 18, 2023
View reviewed changes
pirate
pirate reviewed Oct 18, 2023
View reviewed changes
@pirate pirate merged commit 2a1104c into ArchiveBox:dev Oct 18, 2023
@pirate pirate mentioned this pull request Oct 23, 2023
Merged
30 tasks
@benmuth benmuth deleted the add-user-env-vars branch October 24, 2023 22:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@pirate pirate pirate requested changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@benmuth @pirate