After a timeout, chrome will leave behind a SingletonLock, which prev… #1219
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ents future instances of chrome from starting. When an extractor fails due to a timeout, remove this file.
|
Thanks! This seems like a reasonable workaround for now until I finish the Huey + playwright event driven refactor. |
30 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
After a timeout in the pdf, screenshot, or dom extractor inside a docker container, chrome will leave behind a file at ~/.config/chromium/SingletonLock. This stops all three extractors from functioning until the docker container is completely torn down and regenerated.
This code adds removal of this file after a timeout only when running in a docker container. There is no behavior change outside a docker container. This was a deliberate choice on my part, as I don't want to interfere with a user's running chrome sessions when not running in a docker container.
Related issues
#1181
Changes these areas