Add FAVICON_PROVIDER option for custom favicon service #1146
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This is perfect, thanks! the change to |
30 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Add
FAVICON_PROVIDERoption to allow configuring any favicon service.Tested with The Favicon Finder (a demo deployment of mat/besticon mentioned in the related issue), and also with Favicon Kit.
e.g.
archivebox config --set FAVICON_PROVIDER='https://besticon-demo.herokuapp.com/icon?url={}&size=32..64..64'Questions
I noticed that the Google URL was hard-coded in two places:
archivebox/extractors/favicon.pyandarchivebox/index/schema.py. I made changes in both, but I'm not sure if I should have done the latter -- the top of that file says not to add any more features to the file. Is it better to leave it as is, with the old hard-coded Google URL, or change it?Related issues
#1117
Changes these areas