add CHROME_TIMEOUT args #1120
Merged
add CHROME_TIMEOUT args #1120
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: ふぁ <[email protected]>
|
Thanks! I confirmed it seems to be a recent change they made: https://developer.chrome.com/articles/new-headless/ |
This seems to be implemented in v112, so it doesn't seem to affect v111, but v111 seems to be unstable due to this. |
|
I have set up Issues regarding this. #1122 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
CHROME_TIMEOUTargsEnvironment
Chromium 111.0.5563.64 snapWhy
Chromium
--timeoutargument doesn't actually do timeout behavior.For example, when
--screenshotargument is given, it delays the shooting for the time specified by the timeout.Not sure if this behavior is caused by chromium v111.
Note
CHROME_TIMEOUT is set to 0 by default.
For example, when
--screenshotargument is given, If timeout is set to 0, the image is captured at the same time DOMContentLoaded fires, so some Web sites may not be captured as intended.When set to 1 or higher, the possibility of getting the desired photo increases dramatically.
Related
606fa39
Changes these areas