Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Feature Request: Cookies.txt use for singlefile #829

Open
6 of 9 tasks
TheAnachronism opened this issue Aug 16, 2021 · 3 comments
Open
6 of 9 tasks

Feature Request: Cookies.txt use for singlefile #829

TheAnachronism opened this issue Aug 16, 2021 · 3 comments
Labels
expected: maybe someday help wanted size: medium status: backlog Work is planned someday but is not the highest priority at the moment status: idea-phase Work is tentatively approved and is being planned / laid out, but is not ready to be implemented yet touches: configuration why: functionality Intended to improve ArchiveBox functionality or features

Comments

@TheAnachronism
Copy link

Type

  • General question or discussion
  • Propose a brand new feature
  • Request modification of existing behavior or design

What is the problem that your feature request solves

The singlefile CLI supports a cookies.txt file too:
gildas-lormeau/SingleFile#574
Would it be possible to also use this here?
If it's available for wget it should be possible for singlefile too

Describe the ideal specific solution you'd want, and whether it fits into any broader scope of changes

Restricted websites can be archived with more then just wget or a configured chrome binary.

What hacks or alternative solutions have you tried to solve the problem?

Speaking about singlefile, only manually using the webextension and then upload it in the correct directory.

How badly do you want this new feature?

  • It's an urgent deal-breaker, I can't live without it
  • It's important to add it in the near-mid term future
  • It would be nice to have eventually
  • I'm willing to contribute dev time / money to fix this issue
  • I like ArchiveBox so far / would recommend it to a friend
  • I've had a lot of difficulty getting ArchiveBox set up
@TheAnachronism TheAnachronism added the status: idea-phase Work is tentatively approved and is being planned / laid out, but is not ready to be implemented yet label Aug 16, 2021
@TheAnachronism
Copy link
Author

I'm not experienced in python at all but have quite a bit of coding experience, so for the start I'll just go through the code and propose the changes here

@TheAnachronism
Copy link
Author

Alright so I guess this entire thing shouldn't be that hard.
Looking at https://github.com/ArchiveBox/ArchiveBox/blob/dev/archivebox/extractors/wget.py only COOKIES_FILE has to be added to the config imports and cli argument has to added to the cmd object on line 48 in https://github.com/ArchiveBox/ArchiveBox/blob/dev/archivebox/extractors/singlefile.py.

Because this entire thing doesn't seem to big, how fast could this get implemented? (Not really that important but was just wondering)

@pirate
Copy link
Member

pirate commented Aug 19, 2021 •
edited
Loading

It may have to wait till after I get back from vacation in October / Dec, and even then it's lower priority than some of our pending refactors.

If you PR it then as fast as you want ;) I don't think it would take more than a day to implement, test, and document it.

@pirate pirate added size: medium touches: configuration why: functionality Intended to improve ArchiveBox functionality or features help wanted status: backlog Work is planned someday but is not the highest priority at the moment type: enhancement expected: maybe someday labels Jan 19, 2024
@naoph naoph mentioned this issue Mar 3, 2024
Merged
6 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
expected: maybe someday help wanted size: medium status: backlog Work is planned someday but is not the highest priority at the moment status: idea-phase Work is tentatively approved and is being planned / laid out, but is not ready to be implemented yet touches: configuration why: functionality Intended to improve ArchiveBox functionality or features
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@pirate @TheAnachronism