Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Bug: Admin panel actions do not work in Safari and Epiphany #658

Closed
berezovskyi opened this issue Feb 27, 2021 · 11 comments
Closed

Bug: Admin panel actions do not work in Safari and Epiphany #658

berezovskyi opened this issue Feb 27, 2021 · 11 comments
Labels
size: easy status: wip Work is in-progress / has already been partially completed
Milestone
v0.6.3

Comments

@berezovskyi
Copy link

berezovskyi commented Feb 27, 2021 •
edited
Loading

Describe the bug

"No action selected." error is returned from the admin pages when trying to run actions like Archive via Safari.

Steps to reproduce

  1. Open http://%HOST%/admin/core/snapshot/?p=1 page
  2. Select a few entries by ticking the checkboxes.
  3. Click the Archive button.

Screenshots or log output

Before:

image

After:

image

  • Safari 14.0.3 on latest Catalina update.
  • Content blockers disabled.
  • Cross-site tracking prevention disabled.
  • Extensions enabled are Instapaper and Bitwarden but should not affect this.

Console does not show any errors except the favicon 404s. This exact sequence of steps works perfectly well in FF, Chrome, Brave on macOS. DOES NOT work on GNOME Web (aka Epiphany) on Linux. I tried to searching for Django Admin problems with actions in Webkit but maybe I was not making specific enough queries to pinpoint this.

ArchiveBox version

replace this line with the *full*, unshortened output of running `archivebox version`

ArchiveBox v0.5.6
Cpython Linux Linux-5.8.0-43-generic-x86_64-with-glibc2.28 x86_64 (in Docker)

[i] Dependency versions:
 √  ARCHIVEBOX_BINARY     v0.5.6          valid     /usr/local/bin/archivebox
 √  PYTHON_BINARY         v3.9.1          valid     /usr/local/bin/python3.9
 √  DJANGO_BINARY         v3.1.3          valid     /usr/local/lib/python3.9/site-packages/django/bin/django-admin.py
 √  CURL_BINARY           v7.64.0         valid     /usr/bin/curl
 √  WGET_BINARY           v1.20.1         valid     /usr/bin/wget
 √  NODE_BINARY           v15.8.0         valid     /usr/bin/node
 √  SINGLEFILE_BINARY     v0.1.14         valid     /node/node_modules/single-file/cli/single-file
 √  READABILITY_BINARY    v0.1.0          valid     /node/node_modules/readability-extractor/readability-extractor
 √  MERCURY_BINARY        v1.0.0          valid     /node/node_modules/@postlight/mercury-parser/cli.js
 √  GIT_BINARY            v2.20.1         valid     /usr/bin/git
 √  YOUTUBEDL_BINARY      v2021.02.04.1   valid     /usr/local/bin/youtube-dl
 √  CHROME_BINARY         v88.0.4324.146  valid     /usr/bin/chromium
 √  RIPGREP_BINARY        v0.10.0         valid     /usr/bin/rg

[i] Source-code locations:
 √  PACKAGE_DIR           22 files        valid     /app/archivebox
 √  TEMPLATES_DIR         3 files         valid     /app/archivebox/templates

[i] Secrets locations:
 -  CHROME_USER_DATA_DIR  -               disabled
 -  COOKIES_FILE          -               disabled

[i] Data locations:
 √  OUTPUT_DIR            13 files        valid     /data
 √  SOURCES_DIR           202 files       valid     ./sources
 √  LOGS_DIR              0 files         valid     ./logs
 √  ARCHIVE_DIR           4381 files      valid     ./archive
 √  CONFIG_FILE           1.1 KB          valid     ./ArchiveBox.conf
 √  SQL_INDEX             35.1 MB         valid     ./index.sqlite3
@berezovskyi berezovskyi changed the title Bug: Admin panel actions do not work in Safari Bug: Admin panel actions do not work in Safari and Epiphany Feb 27, 2021
@pirate
Copy link
Member

pirate commented Mar 1, 2021 •
edited
Loading

Interesting, I have not run into this myself in Safari on macOS Big Sur, but I'll check again on v0.6.

@pirate pirate added size: easy is: bug status: done Work is completed and released (or scheduled to be released in the next version) labels Apr 6, 2021
@pirate
Copy link
Member

pirate commented Apr 6, 2021

Fixed in 68a506e. Will be out with the v0.6 release. Comment back if you still have any trouble after that release is out and I'll reopen the issue.

@pirate pirate closed this as completed Apr 6, 2021
@mdbraber
Copy link

Seems that this bug is back? Experiencing the same issue with the dev branch (and 0.6.2) on Safari 14.1 on Big Sur (11.3.1)

@pirate pirate reopened this May 25, 2021
@pirate pirate added status: wip Work is in-progress / has already been partially completed and removed status: done Work is completed and released (or scheduled to be released in the next version) labels Jun 1, 2021
@pirate pirate added this to the v0.6.3 milestone Jun 1, 2021
@rcarmo
Copy link

rcarmo commented Jul 18, 2021

I can confirm this is still an issue with both desktop and mobile Safari, which makes it hard/impossible to use on an iPad.

@pirate pirate mentioned this issue Jul 30, 2021
Merged
30 tasks
@rcarmo
Copy link

rcarmo commented Oct 21, 2021

Hi there. Any quick fix or workaround hack we can do for this in the meantime? I keep stuffing URLs into a note and then filing them via Firefox on my laptop, which is sub-optimal…

adamwolf pushed a commit to adamwolf/ArchiveBox that referenced this issue Oct 29, 2021
Tweak JS so Safari can choose admin actions
83731f5 
I noticed that Safari was submitting both the empty option and the
selected options back to the server.

Digging into it, I was able to get Safari to deselect the ---------
option by using '[selected]' as the selector.

For ArchiveBox#658
@adamwolf adamwolf mentioned this issue Oct 29, 2021
Merged
6 tasks
adamwolf pushed a commit to adamwolf/ArchiveBox that referenced this issue Oct 29, 2021
Fixes Add button behavior on Safari
18e1fb0 
Previously, when you clicked the Add button, the page wouldn't change.

It looked like it wasn't doing anything, as noted by @rcarmo
(ArchiveBox#658 (comment))

I didn't track it down the exact reason why. It may be that Safari
didn't like the two opening <h3>s, but I was able to find a bunch of
people complaining about Safari being very finicky with innerHTML
and actually repainting the page, enough that I decided to try just
extending the block hide/show behavior already done with the
delay-warning, and it works for me now in both Chrome and Safari.

For ArchiveBox#658.
@adamwolf adamwolf mentioned this issue Oct 29, 2021
Merged
6 tasks
@aidenmitchell
Copy link

Still an issue as of v0.6.2 on iPadOS 15.2db2

@pirate
Copy link
Member

pirate commented Nov 12, 2021

It's fixed in v0.6.3 @aidenmitchell , you can run the pre-release version safely by following these instructions: https://github.com/ArchiveBox/ArchiveBox#install-and-run-a-specific-github-branch

@aidenmitchell
Copy link

@pirate Just updated to dev branch, still not working unfortunately.

@pirate
Copy link
Member

pirate commented Nov 12, 2021

Sorry can you re-pull and try again now, I just merged another PR that helps fix it #885

@aidenmitchell
Copy link

Works now, thank you!

@pirate
Copy link
Member

pirate commented Nov 12, 2021

Great, thanks for helping test. I'm going to close this for now as fixed, anyone arriving here can do the same step to run the pre-release version early, or wait for the v0.6.3 release to land.

@pirate pirate closed this as completed Nov 12, 2021
@pirate pirate mentioned this issue Jan 31, 2023
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
size: easy status: wip Work is in-progress / has already been partially completed
Projects
None yet
Milestone
v0.6.3
Development

No branches or pull requests
5 participants
@berezovskyi @rcarmo @pirate @mdbraber @aidenmitchell