Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

New Extractor Idea: gallery-dl for image gallery downloading #564

Open
pirate opened this issue Dec 2, 2020 · 5 comments
Open

New Extractor Idea: gallery-dl for image gallery downloading #564

pirate opened this issue Dec 2, 2020 · 5 comments
Labels
good first ticket help wanted size: medium status: idea-phase Work is tentatively approved and is being planned / laid out, but is not ready to be implemented yet touches: configuration touches: dependencies/packaging Issues or changes that add/remove/affect dependencies why: functionality Intended to improve ArchiveBox functionality or features

Comments

@pirate
Copy link
Member

pirate commented Dec 2, 2020

Add a new extractor for image gallery photo downloading:

https://github.com/mikf/gallery-dl

PRs are welcome for this one! But please discuss your approach here first before starting any work!

@pirate pirate added why: functionality Intended to improve ArchiveBox functionality or features touches: configuration size: medium good first ticket touches: dependencies/packaging Issues or changes that add/remove/affect dependencies help wanted status: idea-phase Work is tentatively approved and is being planned / laid out, but is not ready to be implemented yet labels Dec 2, 2020
@pirate
Copy link
Member Author

pirate commented Jan 12, 2024

@benmuth this is actually higher priority than the upgrade banner stuff, can you switch to working on this when you get a chance?

ArchiveBox's niche is being able to download a wide array of content into its raw constituent parts, and we've been needing a photo gallery downloading ability for a while!


Because this is a larger ticket I'm down to pay out more, I expect it to take a bit of work to prototype and test since it requires touching a lot of different parts of the codebase.

The process to add a new extractor is involved, but fairly well documented here: https://github.com/ArchiveBox/ArchiveBox#contributing-a-new-extractor

Let me know if you have any questions!

@benmuth
Copy link
Contributor

benmuth commented Jan 20, 2024

@pirate Should the media extractor also handle gallery-dl? I'm not sure if the media extractor is just an alias for youtube-dl or if it's supposed to handle other visual media as well.

Related: should gallery-dl config be controlled by the media options similar to the youtube-dl config? For example, should the default value for USE_GALLERYDL be determined by SAVE_MEDIA?

@pirate
Copy link
Member Author

pirate commented Jan 20, 2024

Check out my WIP PR for the new plugin system, I added a placeholder for gallerydl but it's not fleshed out yet.

@benmuth
Copy link
Contributor

benmuth commented Jan 21, 2024

Ah cool! Should I still keep working on a gallery-dl branch based off dev, or should I wait until the plugin system has merged?

@pirate
Copy link
Member Author

pirate commented Jan 23, 2024

Wait until the plugin system has merged @benmuth, thanks. sorry to interrupt your work

@pirate pirate changed the title Feature Request: new extractor gallery-dl for image gallery downloading New Extractor Idea: gallery-dl for image gallery downloading Feb 29, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
good first ticket help wanted size: medium status: idea-phase Work is tentatively approved and is being planned / laid out, but is not ready to be implemented yet touches: configuration touches: dependencies/packaging Issues or changes that add/remove/affect dependencies why: functionality Intended to improve ArchiveBox functionality or features
Projects
None yet
Development

No branches or pull requests

2 participants