Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature Request: Update singlefile to latest version (PR available) #1220

Closed
5 of 9 tasks
spresse1 opened this issue Aug 29, 2023 · 2 comments
Closed
5 of 9 tasks

Feature Request: Update singlefile to latest version (PR available) #1220

spresse1 opened this issue Aug 29, 2023 · 2 comments

Comments

@spresse1
Copy link
Contributor

Type

  • General question or discussion
  • Propose a brand new feature
  • Request modification of existing behavior or design

What is the problem that your feature request solves

The version of SingleFile currently pulled into ArchiveBox is from 2021 and pinned to a specific git commit. SingleFile has since split into the SingleFile browser plugin and single-file-cli and gone to version 1.

Describe the ideal specific solution you'd want, and whether it fits into any broader scope of changes

I've prepared a patch which updates NPM dependencies to pull in single-file-cli with the latest release. In testing using my own docker container, this was a drop-in replacement. I've used it to archive just under 500 pages at this point (importing from pinboard).

I'll open a PR with the patch just as soon as I'm done with this bug report. It's unfortunately a rewrite of the NPM dependency files, but brings many things more up to date.

What hacks or alternative solutions have you tried to solve the problem?

None, wrote the fix.

How badly do you want this new feature?

  • It's an urgent deal-breaker, I can't live without it
  • It's important to add it in the near-mid term future
  • It would be nice to have eventually

  • I'm willing to contribute dev time / money to fix this issue
  • I like ArchiveBox so far / would recommend it to a friend
  • I've had a lot of difficulty getting ArchiveBox set up
@spresse1
Copy link
Contributor Author

One question: I don't see an automated way of getting the latest NPM updates into package-lock.json (but do not regularly develop using NPM). Is the intent that this is done manually?

@pirate
Copy link
Member

pirate commented Aug 30, 2023

Yes, because archival software has slightly different design goals than most software, I don't want to bump dependencies too frequently, lest we create a giant file of archivebox versions that need to be stored for future replaying.

@pirate pirate closed this as completed Aug 30, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants