Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Feature Request: Explicitly specify --headless=new #1122

Closed
2 of 4 tasks
fa0311 opened this issue Mar 16, 2023 · 2 comments
Closed
2 of 4 tasks

Feature Request: Explicitly specify --headless=new #1122

fa0311 opened this issue Mar 16, 2023 · 2 comments
Labels
size: easy status: done Work is completed and released (or scheduled to be released in the next version) touches: dependencies/packaging Issues or changes that add/remove/affect dependencies why: functionality Intended to improve ArchiveBox functionality or features

Comments

@fa0311
Copy link
Contributor

fa0311 commented Mar 16, 2023

Type

  • General question or discussion
  • Propose a brand new feature
  • Request modification of existing behavior or design

What is the problem that your feature request solves

Resolve the problem of unstable headless mode in the current chromium v111.
For example, it can solve the problem of RESOLUTION (--window-size) not working.

Describe the ideal specific solution you'd want, and whether it fits into any broader scope of changes

Change the argument given to chromium to --headless=new

Note

$ /usr/bin/chromium-browser --version
Chromium 111.0.5563.64 snap
Command Img
/usr/bin/chromium-browser --headless --timeout=2000 --screenshot --window-size=1440,2000 https://github.com/ArchiveBox/ screenshot1
/usr/bin/chromium-browser --headless=new --timeout=2000 --screenshot --window-size=1440,2000 https://github.com/ArchiveBox/ screenshot
  • I'm willing to contribute dev time to fix this issue
@fa0311 fa0311 mentioned this issue Mar 16, 2023
Merged
6 tasks
@pirate
Copy link
Member

pirate commented Mar 16, 2023 •
edited
Loading

Want to open a PR so you get the credit 😉 ? I'm also happy to do it

We just have to add a version check and if the version is >= 111 change the argument

@fa0311 fa0311 mentioned this issue Mar 17, 2023
Merged
6 tasks
@pirate
Copy link
Member

pirate commented Jun 13, 2023

closing because PR was merged, thanks again!

@pirate pirate closed this as completed Jun 13, 2023
@pirate pirate added type: bug report why: functionality Intended to improve ArchiveBox functionality or features size: easy touches: dependencies/packaging Issues or changes that add/remove/affect dependencies status: done Work is completed and released (or scheduled to be released in the next version) labels Jun 13, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
size: easy status: done Work is completed and released (or scheduled to be released in the next version) touches: dependencies/packaging Issues or changes that add/remove/affect dependencies why: functionality Intended to improve ArchiveBox functionality or features
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@pirate @fa0311