Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature request: Add ability to point ArchiveBox to a custom favicon service instead of Google #1117

Closed
pirate opened this issue Mar 9, 2023 · 1 comment
Labels
size: medium status: done Work is completed and released (or scheduled to be released in the next version) touches: configuration touches: docs why: security Intended to improve ArchiveBox security or data integrity

Comments

@pirate
Copy link
Member

pirate commented Mar 9, 2023

Just found out that https://github.com/mat/besticon exists. This would allow us to point ArchiveBox at a self-hosted replacement for the Google favicon service we currently use.

The current solution has always mildly irked me as a suboptimal way we leak archived domains to a 3rd party, which is why I document how to disable it here: https://docs.archivebox.io/en/latest/Security-Overview.html#stealth-mode, but it would be nice to provide an alternative other than disabling it entirely.

I'm imagining something like:

archivebox config --set FAVICON_PROVIDER='https://www.google.com/s2/favicons?domain={}' (the default)

that can be set to anything, e.g.:

archivebox config --set FAVICON_PROVIDER='https://someselfhostedservice.example.com/?q={}&format=png&size=64x64'

@pirate pirate added status: idea-phase Work is tentatively approved and is being planned / laid out, but is not ready to be implemented yet size: medium touches: configuration why: security Intended to improve ArchiveBox security or data integrity good first ticket help wanted touches: docs type: enhancement expected: maybe someday labels Mar 9, 2023
@pirate
Copy link
Member Author

pirate commented Jun 13, 2023

closing because PR was merged, thanks!

@pirate pirate closed this as completed Jun 13, 2023
@pirate pirate added status: done Work is completed and released (or scheduled to be released in the next version) and removed status: idea-phase Work is tentatively approved and is being planned / laid out, but is not ready to be implemented yet help wanted good first ticket expected: maybe someday labels Jun 13, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
size: medium status: done Work is completed and released (or scheduled to be released in the next version) touches: configuration touches: docs why: security Intended to improve ArchiveBox security or data integrity
Projects
None yet
Development

No branches or pull requests

1 participant