Enhancement: Add WGET_EXTRA_ARGS
, CURL_EXTRA_ARGS
, SINGLEFILE_EXTRA_ARGS
to extend default args without overriding defaults
#1025
Labels
expected: maybe someday
good first ticket
help wanted
size: easy
status: backlog
Work is planned someday but is not the highest priority at the moment
touches: configuration
why: functionality
Intended to improve ArchiveBox functionality or features
These
WGET_ARGS
,CURL_ARGS
, etc. options let the user shoot themselves in the foot, silently. I think the documentation or the variables themselves should be changed to be more ergonomic.Did you need to add a header to wget?
Look at this configuration, it looks inoffensive. Checking the documention, nothing ticks you off you're using it wrong. But no.
After this, your 🆆 button won't take you to the main html you archived, and wget archives things slighlty differently, silently.
Why? By setting WGET_ARGS you overwrote vital settings, as it turns out they're also stored in WGET_ARGS. The documentation doesn't tell you about this. This happened to me, I just happily overwrote the variable. When I should've written something like this:
Proposal:
*_ARGS
should have a good warning or display the default value, so that users can suspect they're overwriting something.EXTRA_WGET_ARGS
,EXTRA_CURL_ARGS
, and so on. These won't overwrite the now-considered low-level*_ARGS
.EXTRA_*_ARGS
shall be the more user-facing option and more promoted in the documentation.The text was updated successfully, but these errors were encountered: