disable GLOBAL_CONTEXT used by version upgrade banner as not all admin views accept extra_context kwarg

pirate · pirate · commit 4af9beedd137 · 2024-01-03T16:11:27.000-08:00
diff --git a/archivebox/core/urls.py b/archivebox/core/urls.py
@@ -8,11 +8,12 @@
 
 from core.views import HomepageView, SnapshotView, PublicIndexView, AddView, HealthCheckView
 
-from config import VERSION, VERSIONS_AVAILABLE, CAN_UPGRADE
+# GLOBAL_CONTEXT doesn't work as-is, disabled for now: https://github.com/ArchiveBox/ArchiveBox/discussions/1306
+# from config import VERSION, VERSIONS_AVAILABLE, CAN_UPGRADE
+# GLOBAL_CONTEXT = {'VERSION': VERSION, 'VERSIONS_AVAILABLE': VERSIONS_AVAILABLE, 'CAN_UPGRADE': CAN_UPGRADE}
 
-# print('DEBUG', settings.DEBUG)
 
-GLOBAL_CONTEXT = {'VERSION': VERSION, 'VERSIONS_AVAILABLE': VERSIONS_AVAILABLE, 'CAN_UPGRADE': CAN_UPGRADE}
+# print('DEBUG', settings.DEBUG)
 
 urlpatterns = [
     path('public/', PublicIndexView.as_view(), name='public-index'),
@@ -33,7 +34,10 @@
 
 
     path('accounts/', include('django.contrib.auth.urls')),
-    path('admin/', admin.site.urls, {'extra_context': GLOBAL_CONTEXT}),
+    path('admin/', admin.site.urls),
+    
+    # do not add extra_context like this as not all admin views (e.g. ModelAdmin.autocomplete_view accept extra kwargs)
+    # path('admin/', admin.site.urls, {'extra_context': GLOBAL_CONTEXT}),
 
     path('health/', HealthCheckView.as_view(), name='healthcheck'),
     path('error/', lambda _: 1/0),
