Skip to content

DS3: Update the setup guide#878

Merged
black-sliver merged 7 commits intoArchipelagoMW:mainfrom
Marechal-L:ds3_update_setup_guide
Aug 13, 2022
Merged

DS3: Update the setup guide#878
black-sliver merged 7 commits intoArchipelagoMW:mainfrom
Marechal-L:ds3_update_setup_guide

Conversation

@Marechal-L
Copy link
Collaborator

As suggested in the Discord, I share a pull-request to rephrase the installation procedures regarding the AP.json file to reduce the number of technical support on this point

@black-sliver black-sliver added the is: documentation Improvements or additions to documentation. label Aug 9, 2022
@Marechal-L
Copy link
Collaborator Author

Also added information on how to complete the game and a French setup guide

Copy link
Member

@black-sliver black-sliver left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sorry for nitpicking

@Marechal-L
Copy link
Collaborator Author

No problem about the nitpicking, it's been a long time since I wrote markdown and it is always good to learn something.
Do you have a lint or a plugin to detect the whitespace errors easily in Pycharm ?

@black-sliver
Copy link
Member

No problem about the nitpicking, it's been a long time since I wrote markdown and it is always good to learn something.
Do you have a lint or a plugin to detect the whitespace errors easily in Pycharm ?

Not really. In firefox on github you see the whitespaces when you select the text, so that's what i've been using to check for whitespace errors. gedit (and other text edtiros) only highlight the double white-space at end of line.

Single whitespace errors in md are not really a big deal, the extra double are though, because they may (or may not) produce a <br/> that may or may not break the layout

Comment on lines 26 to 27
- **AP.json** : Le fichier .json téléchargé depuis la <em>room</em> ou donné par l'hôte de la partie, nommé
AP-{ROOM_ID}.json, doit être renommé en AP.json.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think i found one last thing, and then we can merge:

Suggested change
- **AP.json** : Le fichier .json téléchargé depuis la <em>room</em> ou donné par l'hôte de la partie, nommé
AP-{ROOM_ID}.json, doit être renommé en AP.json.
- **AP.json** : Le fichier .json téléchargé depuis la <em>room</em> ou donné par l'hôte de la partie, nommé
AP-{ROOM_ID}.json, doit être renommé en AP.json.

@black-sliver
Copy link
Member

Thanks!

@black-sliver black-sliver merged commit 0ed0d17 into ArchipelagoMW:main Aug 13, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

is: documentation Improvements or additions to documentation.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants